Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Applicative for Forget #107

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Add Applicative for Forget #107

merged 2 commits into from
Nov 3, 2023

Conversation

echatav
Copy link
Contributor

@echatav echatav commented Oct 21, 2023

This adds an Applicative instance for Forget, in line with its Monoid instance.

This adds an Applicative instance for Forget, making it a lax monoidal profunctor in line with its Monoid instance.
@RyanGlScott
Copy link
Collaborator

Sorry for taking so long to review this.

I think the CI bitrotted, so I pushed 2c9fd4c to main in an effort to get it to a working state. Can you rebase your PR on top of main?

@echatav
Copy link
Contributor Author

echatav commented Nov 3, 2023

Sure thing, thanks.

@RyanGlScott RyanGlScott merged commit 3fb1953 into ekmett:main Nov 3, 2023
7 checks passed
@echatav echatav deleted the applicative-forget branch November 3, 2023 12:28
RyanGlScott added a commit that referenced this pull request Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants