Skip to content

Commit

Permalink
C bindings are required to build Python package (#883)
Browse files Browse the repository at this point in the history
* Don't attempt to build C bindings for Python package

* Add workflow stage to do a test build of the SDist
  • Loading branch information
jonathanhogg authored Aug 3, 2024
1 parent a37d59e commit 7ad7703
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: build_wheels

on:
on:
release:
types: [published]
workflow_dispatch:
Expand Down Expand Up @@ -35,6 +35,8 @@ jobs:
submodules: recursive
- name: Build SDist
run: pipx run build --sdist
- name: Confirm SDist can be built
run: pip wheel dist/*.tar.gz
- uses: actions/upload-artifact@v4
with:
name: python-sdist
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ sdist.exclude = [
"oneTBB", # we may have this when we build with cibuildwheel
]
wheel.packages = ["manifold3d"]
cmake.args = ["-DMANIFOLD_PYBIND=ON", "-DMANIFOLD_PAR=TBB", "-DMANIFOLD_TEST=OFF", "-DBUILD_SHARED_LIBS=OFF"]
cmake.args = ["-DMANIFOLD_PYBIND=ON", "-DMANIFOLD_CBIND=OFF", "-DMANIFOLD_PAR=TBB", "-DMANIFOLD_TEST=OFF", "-DBUILD_SHARED_LIBS=OFF"]
install.components = ["bindings"]

[tool.cibuildwheel]
Expand Down

0 comments on commit 7ad7703

Please sign in to comment.