Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate version.h for emscripten build #1055

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

pca006132
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (d437097) to head (b88efec).
Report is 158 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
- Coverage   91.84%   84.69%   -7.15%     
==========================================
  Files          37       62      +25     
  Lines        4976     9685    +4709     
  Branches        0     1050    +1050     
==========================================
+ Hits         4570     8203    +3633     
- Misses        406     1482    +1076     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll let you merge it, since I'm not sure if you need any other feedback first.

@pca006132 pca006132 merged commit 125dbd4 into elalish:master Nov 18, 2024
23 checks passed
@pca006132 pca006132 deleted the wasm-version.h branch November 18, 2024 04:31
@elalish elalish mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants