-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix perf test #575
Fix perf test #575
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Can you give some before & after numbers to quantify? It would also be helpful to see the multi-threaded comparison. @ochafik Would you like to review this? I'm not sure why these changes would make much difference. |
I think this is written before the lazy csg pr? Previously translate mutates the original object, but now it does not. But I don't see anything that changes the performance... |
OK I got some numbers:
note that some overhead is spent on converting manifold sphere to mesh and import into cgal. |
so I guess this is good, and we just need to wait for CLA? |
The benches between manifold and CGAL were not doing the same thing so comparing runtimes was meaningless. Now they are doing the same thing. |
yes thanks a lot, we were unaware of this because we changed the API a year ago and did not run this benchmark for a long time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Any trouble signing the CLA? Generally the individual one is much easier than the corporate one, if that's helpful.
It's signed but does not show up yet. |
do translate the sphere
the runtime and output are now similar for CGAL and Manifold (tested with one thread).