Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix osx 10.13 error #577

Merged
merged 3 commits into from
Oct 15, 2023
Merged

fix osx 10.13 error #577

merged 3 commits into from
Oct 15, 2023

Conversation

pca006132
Copy link
Collaborator

Fix #576

@kahays can you verify if this works for you now?

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (062399c) 91.18% compared to head (eb70435) 91.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
- Coverage   91.18%   91.15%   -0.03%     
==========================================
  Files          35       35              
  Lines        4570     4570              
==========================================
- Hits         4167     4166       -1     
- Misses        403      404       +1     
Files Coverage Δ
src/manifold/src/csg_tree.cpp 90.65% <50.00%> (-0.35%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kahays
Copy link

kahays commented Oct 14, 2023

Thank you, this solves the issues with csg_tree.cpp!

Looks like a few more issues cropped up in bindings/python/manifold3d.cpp, all of the form error: call to unavailable member function 'value': introduced in macOS 10.14.

bindings/python/manifold3d.cpp:325:29: error: call to unavailable member function 'value': introduced in macOS 10.14
if (normalIdx.value().ndim() != 1 ||
bindings/python/manifold3d.cpp:326:29: error: call to unavailable member function 'value': introduced in macOS 10.14
normalIdx.value().shape(0) != 3)
bindings/python/manifold3d.cpp:328:38: error: call to unavailable member function 'value': introduced in macOS 10.14
auto value = normalIdx.value();
bindings/python/manifold3d.cpp:627:49: error: call to unavailable member function 'value': introduced in macOS 10.14
auto runTransform1 = runTransform.value();
bindings/python/manifold3d.cpp:640:55: error: call to unavailable member function 'value': introduced in macOS 10.14
auto halfedgeTangent1 = halfedgeTangent.value();

Not sure if it preserves semantics appropriately but I changed each variable.value().method() invocation with (*variable).method(), which allows it to compile.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pca006132
Copy link
Collaborator Author

@kahays updated now, please check if it works. Also it is annoying that we cannot specify OSX 10.13 in github action because they don't plan to support such an old version.

@kahays
Copy link

kahays commented Oct 15, 2023

Thank you, this fixes all the compilation issues! Tests pass just fine too. I really appreciate all your help getting this running on my ancient machine.

@elalish elalish merged commit bec8164 into elalish:master Oct 15, 2023
18 checks passed
@elalish elalish mentioned this pull request Nov 3, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
* fix osx 10.13 error

* errors regarding std::optional

* format
@pca006132 pca006132 deleted the fix-osx-10.13 branch November 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for OS X 10.13?
3 participants