-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix osx 10.13 error #577
fix osx 10.13 error #577
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
==========================================
- Coverage 91.18% 91.15% -0.03%
==========================================
Files 35 35
Lines 4570 4570
==========================================
- Hits 4167 4166 -1
- Misses 403 404 +1
☔ View full report in Codecov by Sentry. |
Thank you, this solves the issues with Looks like a few more issues cropped up in
Not sure if it preserves semantics appropriately but I changed each |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@kahays updated now, please check if it works. Also it is annoying that we cannot specify OSX 10.13 in github action because they don't plan to support such an old version. |
Thank you, this fixes all the compilation issues! Tests pass just fine too. I really appreciate all your help getting this running on my ancient machine. |
* fix osx 10.13 error * errors regarding std::optional * format
Fix #576
@kahays can you verify if this works for you now?