Elastic.Apm.Ingest, new PayloadSender implementation #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `ApmChannel` class that extends the `TransportChannelBase` to provide event ingestion to APM server, which sends V2 intake API data. Also updated the implementation of `IMetricSet`, `ITransaction`, `IError` and `ISpan` to include an `IIntakeRoot` interface which is used to define the incoming root JSON structure to APM server. Updated several dependency versions in some projects. Also added reference to `Elastic.Ingest.Transport` in `Elastic.Apm.csproj`, enabling data transport using our shared infrastructure. Added new files `ApmChannelOptions` and `IIntakeRoot` to manage channel options and declare the interface for incoming JSON data structure respectively. `IntakeErrorItem` and `EventIntakeResponse` are created to handle responses from ingestion processes.
Mpdreamz
force-pushed
the
feature/apm-channel-intake
branch
from
538aa1b to
df0e533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
ApmChannelanElastic.Ingest.Tranportimplementation geared to APM Servers v2 intake API.Opening this early to iterate on as time allows.
MockPayloadSenderis now a subclass ofApmChannelso it will attempt to do the same work as it does.Still need to work on ensuring the data that will get written is correct.