Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-release: doc update 1.25.0 #2204

Merged
merged 3 commits into from
Oct 19, 2023
Merged

post-release: doc update 1.25.0 #2204

merged 3 commits into from
Oct 19, 2023

Conversation

Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented Oct 19, 2023

Manual test run of changes suggested in #2201

The same as #2203 but now including CHANGELOG.asciidoc

git checkout 1.x -b update/docs-1.25.0
git format-patch -k --stdout 1.x...main -- docs CHANGELOG.asciidoc | git am -3 -k
gh pr create --base "1.x" --title "post-release: doc update 1.25.0" --body "Manual test run of changes suggested in #2201"

I am on the latest gh but I am not seeing --repo as a flag @v1v

@v1v
Copy link
Member

v1v commented Oct 19, 2023

I am on the latest gh but I am not seeing --repo as a flag @v1v

In my case I'm using

gh version
gh version 2.34.0 (2023-09-06)
https://github.com/cli/cli/releases/tag/v2.34.0

and --repo is shwon when I run:

$ gh pr create --help
...

INHERITED FLAGS
      --help                     Show help for command
  -R, --repo [HOST/]OWNER/REPO   Select another repository using the [HOST/]OWNER/REPO format

I've just upgraded gh

$ brew upgrade gh
...
$  gh version
gh version 2.37.0 (2023-10-17)
https://github.com/cli/cli/releases/tag/v2.37.0

with the same outcome

@Mpdreamz
Copy link
Member Author

Ahh, the help text that gets printed when a parsing error occurs does not list the inherited flags. I see --repo now 😸

@Mpdreamz Mpdreamz merged commit c5527e8 into 1.x Oct 19, 2023
6 checks passed
@Mpdreamz Mpdreamz deleted the update-docs/1.25.0 branch October 19, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants