Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflow permissions #2300

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Update workflow permissions #2300

merged 4 commits into from
Feb 23, 2024

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented Feb 23, 2024 •
edited
Loading

As titled, this adds what I hope are the missing permissions for these actions.

Test reporter permissions based on: https://github.com/dorny/test-reporter#recommended-setup-for-public-repositories

It's possible we need to open these up further, but let's try these first.

Mpdreamz
Mpdreamz previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM would be good to get someone from robots to okay this too

@stevejgordon
Copy link
Contributor Author

@v1v Perhaps you could also take a look? We accepted the original PR #2288 to add permissions blocks but it appears we need more permissions for these to run.

v1v
v1v previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

.github/workflows/labeler.yml Outdated Show resolved Hide resolved
@stevejgordon stevejgordon dismissed stale reviews from v1v and Mpdreamz via ae72d6c February 23, 2024 14:38
v1v
v1v previously approved these changes Feb 23, 2024
View reviewed changes
@stevejgordon
Copy link
Contributor Author

@v1v / @Mpdreamz Sorry, but I need a fresh approval to merge after committing the proposed changes.

@stevejgordon stevejgordon merged commit 957d80e into main Feb 23, 2024
11 checks passed
@trentm trentm mentioned this pull request Mar 7, 2024
Merged
@stevejgordon stevejgordon deleted the workflow-permissions branch October 3, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

@v1v v1v v1v left review comments

Assignees
No one assigned
Labels
agent-dotnet
Projects
APM-Agents (OLD)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevejgordon @Mpdreamz @v1v