Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to artifact-upload and artifact-download v4 #2124

Merged
merged 3 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build-distribution/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ runs:
run: ./dev-utils/make-distribution.sh
shell: bash

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: build-distribution
path: ./build/
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-distribution
path: ./build
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
username: ${{ secrets.ELASTIC_DOCKER_USERNAME }}
password: ${{ secrets.ELASTIC_DOCKER_PASSWORD }}

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: build-distribution
path: ./build
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/run-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ jobs:
LOCALSTACK_VOLUME_DIR: localstack_data
- if: success() || failure()
name: Upload JUnit Test Results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results
name: test-results-${{ matrix.framework }}-${{ matrix.version }}
path: "**/*-python-agent-junit.xml"
- if: success() || failure()
name: Upload Coverage Reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage-reports
name: coverage-reports-${{ matrix.framework }}-${{ matrix.version }}
path: "**/.coverage*"
include-hidden-files: true
4 changes: 2 additions & 2 deletions .github/workflows/test-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
ENDOFFILE
- if: success() || failure()
name: Upload JUnit Test Results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results
name: test-results-docs
path: "docs-python-agent-junit.xml"
19 changes: 11 additions & 8 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,16 +145,18 @@ jobs:
run: .\scripts\run-tests.bat
- if: success() || failure()
name: Upload JUnit Test Results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-results
name: test-results-${{ matrix.framework }}-${{ matrix.version }}-asyncio-${{ matrix.asyncio }}
path: "**/*-python-agent-junit.xml"
retention-days: 1
- if: success() || failure()
name: Upload Coverage Reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: coverage-reports
name: coverage-reports-${{ matrix.framework }}-${{ matrix.version }}-asyncio-${{ matrix.asyncio }}
path: "**/.coverage*"
retention-days: 1
# This job is here to have a single status check that can be set as required.
# https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds
# If a run contains a series of jobs that need each other, a failure applies to all jobs in the dependency chain from the point of failure onwards.
Expand Down Expand Up @@ -197,9 +199,10 @@ jobs:

- run: python -Im pip install --upgrade coverage[toml]

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: coverage-reports
pattern: coverage-reports-*
merge-multiple: true

- name: Combine coverage & fail if it's <84%.
run: |
Expand All @@ -217,6 +220,6 @@ jobs:
with:
name: html-coverage-report
path: htmlcov
- uses: geekyeggo/delete-artifact@f275313e70c08f6120db482d7a6b98377786765b
- uses: geekyeggo/delete-artifact@f275313e70c08f6120db482d7a6b98377786765b # 5.1.0
with:
name: coverage-reports
name: coverage-reports-*
Loading