Optimize batch usage #157
Open
Optimize batch usage #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
force-pushed
the
batch-optimization
branch
from
9153032 to
2b0fd76
Compare
|
@lahsivjar I've updated the PR to use our fork. Does this need more benchmarks ? Can we merge this ? |
The benchmarks shared were done quite a while ago. We should do another round of benchmarking first before proceeding further. |
|
Thanks @lahsivjar 🙇 Could you run the benchmarks again ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details are in https://github.com/elastic/apm-aggregation-service/issues/366#issuecomment-1846936193
Requires cockroachdb/pebble#3139
More benchmarking required before ready for merging.