Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Secure communication #10841

Merged
merged 5 commits into from
May 22, 2023
Merged

docs: Secure communication #10841

merged 5 commits into from
May 22, 2023

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented May 17, 2023

Summary

This is a mostly structural PR that combines our multiple "Secure" documentation topics into one.

I'm looking for feedback on if this structure makes sense:

Preview this PR -- use the links above!

Screenshot 2023-05-17 at 11 50 49 AM Screenshot 2023-05-17 at 11 50 55 AM

Out of scope

Once we nail down a layout, some content in this section needs to be updated. Reviewing this content is out of scope for this PR and will be addressed in a follow-up PR:

  • Create a writer user: privileges out of date
  • Create an API Key user: open issue docs: Update standalone apm server API key required privileges #10057 for updating privileges
  • Create a central config user: needs to be updated to reflect the changes to central config
  • Grant access using API keys: still reference old apm-* indices and not the correct privileges

@mergify
Copy link
Contributor

mergify bot commented May 17, 2023

This pull request does not have a backport label. Could you fix it @bmorelli25? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 17, 2023
@apmmachine
Copy link
Contributor

apmmachine commented May 17, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-22T02:10:07.779+0000

  • Duration: 3 min 49 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@bmorelli25 bmorelli25 requested a review from a team May 17, 2023 18:47
@bmorelli25 bmorelli25 self-assigned this May 17, 2023
docs/legacy/feature-roles.asciidoc Show resolved Hide resolved
Comment on lines 23 to 24
// Linux Seccomp
include::{docdir}/legacy/copied-from-beats/docs/security/linux-seccomp.asciidoc[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seccomp configuration is unrelated to communication with the stack

I think we should just remove the seccomp section altogether. The only time we fork/exec is for the java attacher, and disallowing those syscalls will break that feature. Otherwise if you want to disallow syscalls it's better to apply seccomp rules in the calling environment, e.g. using systemd sandboxing or Docker seccomp config.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 did you see this comment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Thanks for the bump on this! Removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@simitt please shout if you think we should still document seccomp. You may recall we disabled it by default a while back. I think it's still possible to configure, but as mentioned above I think we should guide users to external configuration for this, if needed at all.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

This pull request is now in conflicts. Could you fix it @bmorelli25? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ft-secure-pt2 upstream/ft-secure-pt2
git merge upstream/main
git push upstream ft-secure-pt2

…secure-pt2

# Conflicts:
#	docs/integrations-index.asciidoc
@bmorelli25 bmorelli25 requested a review from a team May 21, 2023 20:58
@bmorelli25 bmorelli25 merged commit 214acc5 into elastic:main May 22, 2023
@bmorelli25 bmorelli25 deleted the ft-secure-pt2 branch May 22, 2023 15:06
bmorelli25 added a commit to bmorelli25/apm-server that referenced this pull request May 23, 2023
* rest of secure docs

* per @simitt, remove addtl users and roles

* remove linux seccomp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants