-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Secure communication #10841
docs: Secure communication #10841
Conversation
This pull request does not have a backport label. Could you fix it @bmorelli25? 🙏
NOTE: |
docs/secure-comms.asciidoc
Outdated
// Linux Seccomp | ||
include::{docdir}/legacy/copied-from-beats/docs/security/linux-seccomp.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seccomp configuration is unrelated to communication with the stack
I think we should just remove the seccomp section altogether. The only time we fork/exec is for the java attacher, and disallowing those syscalls will break that feature. Otherwise if you want to disallow syscalls it's better to apply seccomp rules in the calling environment, e.g. using systemd sandboxing or Docker seccomp config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmorelli25 did you see this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops. Thanks for the bump on this! Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@simitt please shout if you think we should still document seccomp. You may recall we disabled it by default a while back. I think it's still possible to configure, but as mentioned above I think we should guide users to external configuration for this, if needed at all.
This pull request is now in conflicts. Could you fix it @bmorelli25? 🙏
|
…secure-pt2 # Conflicts: # docs/integrations-index.asciidoc
* rest of secure docs * per @simitt, remove addtl users and roles * remove linux seccomp
Summary
This is a mostly structural PR that combines our multiple "Secure" documentation topics into one.
I'm looking for feedback on if this structure makes sense:
Preview this PR -- use the links above!
Out of scope
Once we nail down a layout, some content in this section needs to be updated. Reviewing this content is out of scope for this PR and will be addressed in a follow-up PR: