Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent spec bypass proxy for cloud metadata #785

Merged
merged 3 commits into from
Apr 19, 2023
Merged

agent spec bypass proxy for cloud metadata #785

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb16476
try to bypass proxy for metadata
SylvainJuge Apr 12, 2023
23dca9d
Apply suggestions from code review
SylvainJuge Apr 13, 2023
c9199f4
add more context why it makes sense
SylvainJuge Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions specs/agents/metadata.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,12 @@ Fetching of cloud metadata for services running as AWS Lambda functions follow a

[Metadata about an EC2 instance](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-retrieval.html) can be retrieved from the internal metadata endpoint, `http://169.254.169.254`.

In the case where a proxy is configured on the application, the agents SHOULD attempt to make
the calls to the metadata endpoint directly, without using the proxy.
This is recommended as those HTTP calls could be caller-sensitive and have to be made directly
by the virtual machine where the APM agent executes, also, the `169.254.x.x` IP address range
is reserved for "link-local" addresses that are not routed.

As an example with curl, first, an API token must be created

```sh
Expand Down Expand Up @@ -238,6 +244,12 @@ From the returned metadata, the following fields are useful
Metadata about a GCP machine instance can be retrieved from the
metadata service, `http://metadata.google.internal`.

In the case where a proxy is configured on the application, the agents SHOULD attempt to make
the calls to the metadata endpoint directly, without using the proxy.
This is recommended as those HTTP calls could be caller-sensitive and have to be made directly
by the virtual machine where the APM agent executes, also, the `169.254.x.x` IP address range
is reserved for "link-local" addresses that are not routed.

An example with curl

```sh
Expand All @@ -264,6 +276,12 @@ From the returned metadata, the following fields are useful
Metadata about an Azure VM can be retrieved from the internal metadata
endpoint, `http://169.254.169.254`.

In the case where a proxy is configured on the application, the agents SHOULD attempt to make
the calls to the metadata endpoint directly, without using the proxy.
This is recommended as those HTTP calls could be caller-sensitive and have to be made directly
by the virtual machine where the APM agent executes, also, the `169.254.x.x` IP address range
is reserved for "link-local" addresses that are not routed.

An example with curl

```sh
Expand Down