Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecs-log-zerolog #2916

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Add ecs-log-zerolog #2916

merged 2 commits into from
Feb 2, 2024

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 requested a review from a team as a code owner January 31, 2024 22:28
@bmorelli25 bmorelli25 self-assigned this Jan 31, 2024
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25
Copy link
Member Author

@elasticmachine, run elasticsearch-ci/docs

@colleenmcginnis
Copy link
Contributor

Hmmm this new book is showing up in the Jenkins preview, but not in the Buildkite preview. @bmorelli25 is that expected?

@bmorelli25
Copy link
Member Author

Hmmm this new book is showing up in the Jenkins preview, but not in the Buildkite preview. @bmorelli25 is that expected?

Yes. I forgot to rerun the BK build after elastic/ecs-logging-go-zerolog#10 was merged :) Doing that now.

@bmorelli25
Copy link
Member Author

@colleenmcginnis
Copy link
Contributor

Oh gosh. @bmorelli25 I hate to do this to you after you just rebuilt the preview, but we should probably add this to the dropdown too. 😬

Screenshot 2024-02-02 at 12 45 55 PM

@bmorelli25
Copy link
Member Author

Great catch! On it 🦖

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍩

@bmorelli25 bmorelli25 merged commit 997cf89 into elastic:master Feb 2, 2024
4 checks passed
@bmorelli25 bmorelli25 deleted the add-ecs-zerolog branch February 5, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants