Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 8.x][OpenAPI] Remove self-referential externalDocs (#2925) #2947

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 26, 2024

Backports #2925

@lcawl lcawl marked this pull request as ready for review September 26, 2024 15:58
@lcawl lcawl requested a review from l-trotta September 26, 2024 15:58
@pquentin
Copy link
Member

pquentin commented Sep 27, 2024

@lcawl We don't usually request review for backports, was there anything especially tricky here?

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(had to rebase it to merge it) LGTM!

@lcawl
Copy link
Contributor Author

lcawl commented Sep 27, 2024

@lcawl We don't usually request review for backports, was there anything especially tricky here?

Ah, all the other repos I have to get approval, so if that isn't the case here I must have missed it. Thanks for the clarification!

@lcawl lcawl merged commit 78754cd into 8.x Sep 27, 2024
6 checks passed
@lcawl lcawl deleted the 8x-rm-externalDocs branch September 27, 2024 16:18
@pquentin
Copy link
Member

Kibana and Elasticsearch have backporting automation that doesn't require reviews, but indeed for manual backports the rule is specific to this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants