-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESQL: Generate evaluator factories #100516
Merged
elasticsearchmachine
merged 9 commits into
elastic:main
from
nik9000:esql_gen_tostring_think
Oct 25, 2023
Merged
ESQL: Generate evaluator factories #100516
elasticsearchmachine
merged 9 commits into
elastic:main
from
nik9000:esql_gen_tostring_think
Oct 25, 2023
Commits on Oct 9, 2023
-
ESQL: Generate evaluator factories
This generates the evaluator factories which we'd been implementing inline with `->`. The advantage of generating them is that they have a useful `toString` and class name. These are useful for debugging and let us remove a kind of errant use `ThrowingDriverContext` just to generate a factory description for logging. Now we can just use the generated `toString`.
Configuration menu - View commit details
-
Copy full SHA for 89fe2ed - Browse repository at this point
Copy the full SHA 89fe2edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7432b14 - Browse repository at this point
Copy the full SHA 7432b14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bc3281 - Browse repository at this point
Copy the full SHA 2bc3281View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dc6fbe - Browse repository at this point
Copy the full SHA 8dc6fbeView commit details
Commits on Oct 25, 2023
-
Update x-pack/plugin/esql/compute/ann/src/main/java/org/elasticsearch…
…/compute/ann/Fixed.java Co-authored-by: Alexander Spies <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2717216 - Browse repository at this point
Copy the full SHA 2717216View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78d0f8b - Browse repository at this point
Copy the full SHA 78d0f8bView commit details -
Merge remote-tracking branch 'refs/remotes/nik9000/esql_gen_tostring_…
…think' into esql_gen_tostring_think
Configuration menu - View commit details
-
Copy full SHA for 3263c33 - Browse repository at this point
Copy the full SHA 3263c33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 437fc08 - Browse repository at this point
Copy the full SHA 437fc08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0615cc8 - Browse repository at this point
Copy the full SHA 0615cc8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.