Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): add missing props tables #8126

Conversation

weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Nov 8, 2024

Summary

I added missing props tables to EUI+ pages. Check the issue for the whole list: #139

Screenshot 2024-11-11 at 11 14 26

If you notice any more let me know, I can add them as part of this PR.

QA

Use the staging link from the comment below. Cross-reference with the list in the issue ☝🏻

@weronikaolejniczak weronikaolejniczak added documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog labels Nov 8, 2024
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner November 8, 2024 18:21
@weronikaolejniczak weronikaolejniczak force-pushed the chore/eui-plus-props-tables branch from 357a102 to 045973c Compare November 8, 2024 18:22
@weronikaolejniczak weronikaolejniczak changed the title chore(website): add missing props tables fix(website): add missing props tables Nov 8, 2024
@weronikaolejniczak weronikaolejniczak force-pushed the chore/eui-plus-props-tables branch from 045973c to 535fff7 Compare November 8, 2024 18:38
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ Thanks for adding the missing props tables!

@weronikaolejniczak weronikaolejniczak force-pushed the chore/eui-plus-props-tables branch from 535fff7 to 8aad618 Compare November 12, 2024 11:11
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@weronikaolejniczak weronikaolejniczak merged commit 101322a into elastic:main Nov 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants