[EuiCollapsibleNavBeta] Close popover when clicking on links #8139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sebelga
force-pushed
the
collapsiblenavbeta/closePopover
branch
from
08e7940 to
a97af30
Compare
cee-chen
reviewed
Nov 21, 2024
...src/components/collapsible_nav_beta/collapsible_nav_item/collapsed/collapsed_nav_popover.tsx
Outdated
Show resolved
Hide resolved
cee-chen
reviewed
Nov 21, 2024
...src/components/collapsible_nav_beta/collapsible_nav_item/collapsed/collapsed_nav_popover.tsx
Outdated
Show resolved
Hide resolved
|
Thanks for the review @cee-chen ! Let me know if you are going to push the changes or how do you want to proceed? thanks! 👍 |
|
I'll push up to this branch by my EOD |
… on div wrapper - instead of having to iterate through `items` - this also allows us to add an `event.preventDefault()` escape hatch for consumers who do not want the popover to auto close
+ write unit tests, DRY out types
- while retaining focus and tooltip for keyboard users, and re-showing the tooltip on mouseover
…e mobile overlay flyout as well - less dependent on DOM traversal, also DRYs out logic for checking prevented defaults, etc.
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @sebelga |
|
Thanks for making the changes @cee-chen, LGTM! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've updated the logic to close the popover when clicking a link inside
EuiCollapsibleNavBeta(collapsed state).Fixes elastic/kibana#198870