[Visual Refresh] Fix computed border token mapping #8170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the issue here seems to be that the border token is defined after color tokens and not available
mgadewoll
changed the title
mgadewoll
commented
Nov 19, 2024
packages/eui/src/global_styling/mixins/__snapshots__/_color.test.ts.snap
Show resolved
Hide resolved
cee-chen
reviewed
Nov 19, 2024
mgadewoll
force-pushed
the
eui/theme/borealis-border-fix
branch
from
da5ce24
to
dea713d
Compare
tkajtoch
requested changes
Nov 20, 2024
Thanks for the catch! Updated in this commit. |
|
Preview staging links for this PR:
|
1 task
💚 Build Succeeded
History
|
cee-chen
approved these changes
Nov 20, 2024
tkajtoch
approved these changes
Nov 20, 2024
tkajtoch
pushed a commit
that referenced
this pull request
Nov 20, 2024
tkajtoch
added a commit
to elastic/kibana
that referenced
this pull request
Nov 27, 2024
`v97.3.1-borealis.2`⏩`v98.0.0-borealis.1` _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- # `@elastic/eui` ## [`v98.0.0`](https://github.com/elastic/eui/releases/v98.0.0) **Bug fixes** - Fixed an `EuiDataGrid` bug where column actions where not clickable when `EuiDataGrid` with `columnVisibility.canDragAndDropColumns` was used inside a modal ([#8135](elastic/eui#8135)) **Breaking changes** - Removed `EuiFormRow`'s deprecated `columnCompressedSwitch` display prop. Use `columnCompressed` instead ([#8113](elastic/eui#8113)) # `@elastic/eui-theme-borealis` **Bug fixes** - Fixed computed border token mapping (elastic/eui#8170) Co-authored-by: Elastic Machine <[email protected]>
tkajtoch
pushed a commit
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR merges into a feature branch
This PR fixes an issue with border token mappings for the
Amsterdamtheme, where references to theborder.colorare not actually available in thecolorsdefinitions yet.The tokens use the underlying computed token now instead.
before
after
QA
EuiCommentEventborder for "subdued" event is using proper "subdued" color instead of black (Storybook)