Upgrade Storybook to v8.4 #8173
Conversation
- Storybook will infer this shape automatically if we provide it controls, so do that instead
it's rendering as `-`/false in any case
- by casting to a const
| @@ -189,7 +190,7 @@ | |||
| "eslint-plugin-prettier": "^4.2.1", | |||
| "eslint-plugin-react": "^7.32.2", | |||
| "eslint-plugin-react-hooks": "^4.6.0", | |||
| "eslint-plugin-storybook": "^0.8.0", | |||
| "eslint-plugin-storybook": "^0.9.0", | |||
There was a problem hiding this comment.
I tried updating this to the latest v0.11.1, but it looks like the flat config support they added in v0.10.0 breaks in our version of eslint, so this is likely the highest we can go until we upgrade to eslint v9+
|
Preview staging links for this PR:
|
💚 Build Succeeded
|
There was a problem hiding this comment.
🚢 🐈⬛ Changes are looking good to me 👍
I ran it locally and checked some components and tested related scripts (dev, build, VRT). Everything worked as expected and I didn't see any unexpected issues in my randomly selected story smoke tests.
I re-ran VRT for previously checked components from this PR, and there were still no additional changes 👍
I added a review to unblock following PRs, not sure if @tkajtoch wants to review still anyway.
| @@ -33,6 +33,7 @@ const meta: Meta<EuiColorPickerProps> = { | |||
| display: 'default', | |||
| mode: 'default', | |||
| secondaryInputDisplay: 'none', | |||
| swatches: euiPaletteColorBlind(), | |||
There was a problem hiding this comment.
Borealis mental note: There were changes on the Borealis branch to color palettes and how they update based on theme. These type of calls need to be linked to state to ensure expected updates.
Summary
Storybook 8.3 comes with the ability to set globals at the story level, which I would really like for high contrast mode VRT screenshots 👀 Also it's generally good to stay to date on our dependencies
QA
General checklist
yarn lintpasses