-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(beta_badge): support warning color value #8177
feat(beta_badge): support warning color value #8177
Conversation
3f1a343
to
ae78397
Compare
ae78397
to
ab932f4
Compare
I've experienced the same thing 🤷 @tkajtoch, can you clarify what the developer experience is supposed to be with testing local EUI changes in local EUI+? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for grabbing this Weronika - I'll go ahead and merge this in since it's a straightforward change. I'll pull the question about EUI+ docs to Tomasz out to another thread in Slack.
Preview staging links for this PR:
|
💚 Build Succeeded
History
|
Summary
I added a "warning" value to the color prop, updated both documentation websites and updated snapshot tests.
In the new docs, the warning beta badge doesn't display as expected even after rebuilding dependencies. Not sure if it's a problem with the Docasaurus theme?
closes #8138
QA
General checklist
Checked in mobile(not applicable)Edge, and FirefoxChecked for accessibility including keyboard-only and screenreader modes(not applicable)@default
if default values are missing) and playground togglesChecked Code Sandbox works for any docs examples(not applicable)If applicable, added the breaking change issue label (and filled out the breaking change checklist)(not applicable)