Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(beta_badge): support warning color value #8177

Merged

Conversation

weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Nov 22, 2024

Summary

I added a "warning" value to the color prop, updated both documentation websites and updated snapshot tests.

Screenshot 2024-11-22 at 12 00 48
Screenshot 2024-11-22 at 12 00 56

In the new docs, the warning beta badge doesn't display as expected even after rebuilding dependencies. Not sure if it's a problem with the Docasaurus theme?

Screenshot 2024-11-22 at 12 01 53

closes #8138

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile (not applicable)
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes (not applicable)
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist) (not applicable)
  • Designer checklist

@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review November 22, 2024 11:15
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner November 22, 2024 11:15
@cee-chen
Copy link
Member

In the new docs, the warning beta badge doesn't display as expected even after rebuilding dependencies. Not sure if it's a problem with the Docasaurus theme?

I've experienced the same thing 🤷 @tkajtoch, can you clarify what the developer experience is supposed to be with testing local EUI changes in local EUI+?

Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for grabbing this Weronika - I'll go ahead and merge this in since it's a straightforward change. I'll pull the question about EUI+ docs to Tomasz out to another thread in Slack.

@cee-chen cee-chen enabled auto-merge (squash) November 22, 2024 16:30
@kibanamachine
Copy link

Preview staging links for this PR:

@cee-chen cee-chen merged commit cb1325b into elastic:main Nov 22, 2024
5 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiBetaBadge] Update to include warning color
4 participants