Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v88.5.4 #167555

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Upgrade EUI to v88.5.4 #167555

merged 12 commits into from
Oct 4, 2023

Conversation

cee-chen
Copy link
Member

@cee-chen cee-chen commented Sep 28, 2023

v88.5.0v88.5.4

This EUI upgrade helps unblock the Shared UX team with some beta serverless nav updates not listed in the below changelog (elastic/eui#7228 and elastic/eui#7248).


88.5.4

  • This release contains internal changes to a beta component needed by Kibana.

88.5.3

Bug fixes

  • Fixed EuiComboBox search input width not resetting correctly on selection (#7240)

88.5.2

Bug fixes

  • Fixed broken EuiTextTruncate testenv mocks (#7234)

88.5.1

  • Improved the performance of EuiComboBox by removing the react-autosizer-input dependency (#7215)

Dependency updates

  • Updated react-element-to-jsx-string to v5.0.0 (#7214)
  • Removed unused @types/vfile-message dependency (#7214)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.1.1 labels Sep 29, 2023
@cee-chen cee-chen changed the title Upgrade EUI to v88.5.1 Upgrade EUI to v88.5.2 Sep 29, 2023
@cee-chen cee-chen marked this pull request as ready for review September 29, 2023 22:54
@cee-chen cee-chen requested review from a team as code owners September 29, 2023 22:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen added v8.11.0 and removed v8.1.1 labels Sep 29, 2023
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SharedUX changes LGTM! 🚀 Thanks a lot for bringing this PR ahead of schedule!

@cee-chen cee-chen changed the title Upgrade EUI to v88.5.2 Upgrade EUI to v88.5.3 Oct 2, 2023
Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine area LGTM

@cee-chen
Copy link
Member Author

cee-chen commented Oct 3, 2023

Thanks everyone for the super speedy reviews! 💚 As a heads up, the EUI team will be waiting for the 8.11 branch to be cut before merging, as this upgrade is not critical/necessary to get into 8.11, and we want to reduce FF QA churn.

@cee-chen cee-chen added v8.12.0 and removed v8.11.0 labels Oct 3, 2023
- to grab latest requested serverless nav changes
@cee-chen cee-chen changed the title Upgrade EUI to v88.5.3 Upgrade EUI to v88.5.4 Oct 3, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1423 1425 +2
visTypeVega 309 311 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.7MB 3.7MB -1.0B
fileUpload 957.5KB 957.5KB -1.0B
fleet 1.2MB 1.2MB -1.0B
infra 1.9MB 1.9MB +2.0KB
ingestPipelines 360.8KB 360.8KB -1.0B
visTypeVega 1.8MB 1.8MB +2.0KB
total +4.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-css 275.4KB 275.0KB -475.0B
kbnUiSharedDeps-npmDll 6.2MB 6.2MB -1.3KB
serverlessObservability 43.5KB 43.7KB +225.0B
serverlessSearch 30.2KB 30.4KB +225.0B
total -1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 038ac89 into elastic:main Oct 4, 2023
@cee-chen cee-chen deleted the eui-v88.5.1 branch October 4, 2023 19:32
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants