Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Fix cypress memory issue due to log panel #167623

Merged
merged 4 commits into from
Sep 29, 2023
Merged

[APM] Fix cypress memory issue due to log panel #167623

merged 4 commits into from
Sep 29, 2023

Conversation

achyutjhunjhunwala
Copy link
Contributor

Summary

Recent EUI bump from v88.3.0 to v88.5.0 increased the memory usage significantly. Due to which Cypress Tests started failing due to browser crashing with memory limits. EUI team has been informed about this.

As reverting EUI is not a simple change, disabling the Cypress Log panel solves the problem for now. Details can be found here

This brings change to how we run the Cypress Test in Head Mode

Before

image

After

image (1)

@achyutjhunjhunwala achyutjhunjhunwala added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes labels Sep 29, 2023
@achyutjhunjhunwala achyutjhunjhunwala requested a review from a team as a code owner September 29, 2023 10:57
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Sep 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn mentioned this pull request Sep 29, 2023
Merged
@achyutjhunjhunwala achyutjhunjhunwala merged commit 2047a55 into elastic:main Sep 29, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 29, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the fix-cypress-runner-issue-with-memory branch September 29, 2023 14:33
@achyutjhunjhunwala achyutjhunjhunwala mentioned this pull request Oct 2, 2023
Merged
achyutjhunjhunwala added a commit that referenced this pull request Oct 2, 2023
@achyutjhunjhunwala
[APM] Reverting manual memory fix for cypress post upgrade (#167733)
843dec4 
## Summary

As part of this [PR](#167623),
added a logic to handle hiding of Logs Panels which was consuming a lot
of memory.

With [Cypress Upgrade](#162383) to
13.x, this issue is now fixed and hence this can be reverted.

## How to be sure this works ?
If the PR passes the build, you know it works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@achyutjhunjhunwala @elasticmachine @apmmachine @kibana-ci @sorenlouv @kibanamachine