-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v95.11.0 #192756
Merged
Merged
Upgrade EUI to v95.11.0 #192756
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ddad948
Upgrade EUI to v95.11.0
cee-chen 251155a
i18n updates
cee-chen c494941
[FTR] Update EuiDataGrid service based on DOM cleanup
cee-chen 092a949
[FTR] Harden datagrid cell actions clicking
cee-chen 4eabb39
[Lens][FTR] Fix FTR sorting failure
cee-chen 7a4f633
[ML][FTR] Fix test selector based on removed SR text
cee-chen dd3b630
[ML][FTR] Fix test to account for removed className
cee-chen 83e605d
[Discover][FTR] Update cell headers assertion to account for screen r…
cee-chen 20d184d
[Discover] Clean up EuiDataGrid styles to account for new styles
cee-chen ae8c25b
Fix Enzyme tests to account for new Emotion wrappers
cee-chen 2301ea5
Fix RTL tests with updated DOM
cee-chen 6bdfd0b
Update datagrid cell content test assertion w/ removed screen reader …
cee-chen f2df1a9
Update EuiBasicTable to account for new a11y text
cee-chen 7eeef14
Merge branch 'main' into eui/v95.11.0
cee-chen f8cae9d
[PR feedback] Restore Discover custom header borders
cee-chen dddde79
Merge branch 'main' into eui/v95.11.0
cee-chen b373231
[PR feedback] Revert incorrectly removed styles targeting row cell co…
cee-chen 7d15173
Merge branch 'main' into eui/v95.11.0
cee-chen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,7 +87,7 @@ export const LICENSE_OVERRIDES = { | |
'[email protected]': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts | ||
'@mapbox/[email protected]': ['MIT'], // license in readme https://github.com/tmcw/jsonlint | ||
'@elastic/[email protected]': ['Elastic License 2.0'], | ||
'@elastic/eui@95.10.1': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'], | ||
'@elastic/eui@95.11.0': ['Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0'], | ||
'[email protected]': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry | ||
'[email protected]': ['MIT'], // license in importing module https://www.npmjs.com/package/binary | ||
'@bufbuild/[email protected]': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why this has changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
- a, column 1, row 1
is screen reader only text that I'm currently making several efforts to make less visible to users (e.g. in snapshots, during copy/paste events) while still remaining accessible to screen readers. This snapshot/test assertion change is a result of that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up note: if you still wish to assert on cell col/row placement in EuiDataGrid, please use the
data-gridcell-column-index
anddata-gridcell-visible-row-index
attributes.