Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make panel top nav menu item button full width on mobile #200823

Conversation

paulinashakirova
Copy link
Contributor

@paulinashakirova paulinashakirova commented Nov 19, 2024

Summary

This PR solves [Dashboard] Center Save top nav button for small viewport issue.

Screenshot 2024-11-19 at 23 02 16

Screenshot 2024-11-19 at 23 01 31

The change only affects the mobile menu.

@paulinashakirova paulinashakirova self-assigned this Nov 19, 2024
@paulinashakirova paulinashakirova added release_note:fix Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) papercut Small "burr" in the product that we should fix. v8.17.0 labels Nov 19, 2024
@paulinashakirova paulinashakirova marked this pull request as ready for review November 20, 2024 10:30
@paulinashakirova paulinashakirova requested a review from a team as a code owner November 20, 2024 10:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
navigation 18.3KB 18.3KB +25.0B

History

cc @paulinashakirova

@paulinashakirova paulinashakirova merged commit 971c1f3 into elastic:main Nov 20, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11934851914

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
…c#200823)

## Summary

This PR solves [[Dashboard] Center Save top nav button for small
viewport](elastic#180093 (comment)) issue.

![Screenshot 2024-11-19 at 23 02
16](https://github.com/user-attachments/assets/ac643c61-62d5-4512-af35-33c396f6aba1)

![Screenshot 2024-11-19 at 23 01
31](https://github.com/user-attachments/assets/4d2021fb-a08b-4626-a203-07b52f3cbe55)

The change only affects the mobile menu.

(cherry picked from commit 971c1f3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
…200823) (#200927)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: make panel top nav menu item button full width on mobile
(#200823)](#200823)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Paulina
Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T13:56:41Z","message":"fix:
make panel top nav menu item button full width on mobile (#200823)\n\n##
Summary\r\n\r\nThis PR solves [[Dashboard] Center Save top nav button
for
small\r\nviewport](#180093 (comment))
issue.\r\n\r\n![Screenshot 2024-11-19 at 23
02\r\n16](https://github.com/user-attachments/assets/ac643c61-62d5-4512-af35-33c396f6aba1)\r\n\r\n![Screenshot
2024-11-19 at 23
01\r\n31](https://github.com/user-attachments/assets/4d2021fb-a08b-4626-a203-07b52f3cbe55)\r\n\r\nThe
change only affects the mobile
menu.","sha":"971c1f3c350cd36c6e21441deb5b473f839963cd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-minor","papercut","v8.17.0"],"title":"fix:
make panel top nav menu item button full width on
mobile","number":200823,"url":"https://github.com/elastic/kibana/pull/200823","mergeCommit":{"message":"fix:
make panel top nav menu item button full width on mobile (#200823)\n\n##
Summary\r\n\r\nThis PR solves [[Dashboard] Center Save top nav button
for
small\r\nviewport](#180093 (comment))
issue.\r\n\r\n![Screenshot 2024-11-19 at 23
02\r\n16](https://github.com/user-attachments/assets/ac643c61-62d5-4512-af35-33c396f6aba1)\r\n\r\n![Screenshot
2024-11-19 at 23
01\r\n31](https://github.com/user-attachments/assets/4d2021fb-a08b-4626-a203-07b52f3cbe55)\r\n\r\nThe
change only affects the mobile
menu.","sha":"971c1f3c350cd36c6e21441deb5b473f839963cd"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200823","number":200823,"mergeCommit":{"message":"fix:
make panel top nav menu item button full width on mobile (#200823)\n\n##
Summary\r\n\r\nThis PR solves [[Dashboard] Center Save top nav button
for
small\r\nviewport](#180093 (comment))
issue.\r\n\r\n![Screenshot 2024-11-19 at 23
02\r\n16](https://github.com/user-attachments/assets/ac643c61-62d5-4512-af35-33c396f6aba1)\r\n\r\n![Screenshot
2024-11-19 at 23
01\r\n31](https://github.com/user-attachments/assets/4d2021fb-a08b-4626-a203-07b52f3cbe55)\r\n\r\nThe
change only affects the mobile
menu.","sha":"971c1f3c350cd36c6e21441deb5b473f839963cd"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Paulina Shakirova <[email protected]>
paulinashakirova added a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…c#200823)

## Summary

This PR solves [[Dashboard] Center Save top nav button for small
viewport](elastic#180093 (comment)) issue.

![Screenshot 2024-11-19 at 23 02
16](https://github.com/user-attachments/assets/ac643c61-62d5-4512-af35-33c396f6aba1)

![Screenshot 2024-11-19 at 23 01
31](https://github.com/user-attachments/assets/4d2021fb-a08b-4626-a203-07b52f3cbe55)

The change only affects the mobile menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) papercut Small "burr" in the product that we should fix. release_note:fix Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants