[deprecations/dataviews]: Check in all spaces #202354
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
💚 Build Succeeded
Metrics [docs]
History
cc @afharo |
davismcphee
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Thanks for raising and addressing this, LGTM 👍 I agree about surfacing the spaces to users, and I'm building on this change in #202250 to support showing spaces in the deprecation message:
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
## Summary In order to show all potential deprecations, the SO request should include all spaces by appending `namespaces: ['*']`. This PR adds that, although it doesn't change the test (which, IMO, should include the offending space). Feel free to commit to this PR or to create a follow-up (whatever you prefer). Related: elastic#202341 (cherry picked from commit 5ed54ec)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[deprecations/dataviews]: Check in all spaces (#202354)](#202354) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T15:40:16Z","message":"[deprecations/dataviews]: Check in all spaces (#202354)\n\n## Summary\n\nIn order to show all potential deprecations, the SO request should\ninclude all spaces by appending `namespaces: ['*']`.\n\nThis PR adds that, although it doesn't change the test (which, IMO,\nshould include the offending space). Feel free to commit to this PR or\nto create a follow-up (whatever you prefer).\n\nRelated: https://github.com/elastic/kibana/issues/202341","sha":"5ed54ec93c573f2a23a00d59075000ec085fef98","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[deprecations/dataviews]: Check in all spaces","number":202354,"url":"https://github.com/elastic/kibana/pull/202354","mergeCommit":{"message":"[deprecations/dataviews]: Check in all spaces (#202354)\n\n## Summary\n\nIn order to show all potential deprecations, the SO request should\ninclude all spaces by appending `namespaces: ['*']`.\n\nThis PR adds that, although it doesn't change the test (which, IMO,\nshould include the offending space). Feel free to commit to this PR or\nto create a follow-up (whatever you prefer).\n\nRelated: https://github.com/elastic/kibana/issues/202341","sha":"5ed54ec93c573f2a23a00d59075000ec085fef98"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202354","number":202354,"mergeCommit":{"message":"[deprecations/dataviews]: Check in all spaces (#202354)\n\n## Summary\n\nIn order to show all potential deprecations, the SO request should\ninclude all spaces by appending `namespaces: ['*']`.\n\nThis PR adds that, although it doesn't change the test (which, IMO,\nshould include the offending space). Feel free to commit to this PR or\nto create a follow-up (whatever you prefer).\n\nRelated: https://github.com/elastic/kibana/issues/202341","sha":"5ed54ec93c573f2a23a00d59075000ec085fef98"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to show all potential deprecations, the SO request should include all spaces by appending
namespaces: ['*'].This PR adds that, although it doesn't change the test (which, IMO, should include the offending space). Feel free to commit to this PR or to create a follow-up (whatever you prefer).
Related: #202341