-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Support input variable for integrations package #202362
[Fleet] Support input variable for integrations package #202362
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
cc @nchaulet |
Starting backport for target branches: 8.x |
(cherry picked from commit f21fdaf)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… (#202459) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Support input variable for integrations package (#202362)](#202362) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T13:12:42Z","message":"[Fleet] Support input variable for integrations package (#202362)","sha":"f21fdaf563d9cfcbed2adb61f07346f96045136a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Support input variable for integrations package","number":202362,"url":"https://github.com/elastic/kibana/pull/202362","mergeCommit":{"message":"[Fleet] Support input variable for integrations package (#202362)","sha":"f21fdaf563d9cfcbed2adb61f07346f96045136a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202362","number":202362,"mergeCommit":{"message":"[Fleet] Support input variable for integrations package (#202362)","sha":"f21fdaf563d9cfcbed2adb61f07346f96045136a"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Summary
Input variables used to not be available for integrations package, it seems the support for the UI editor is already done probably with #194310
That PR add the support so the package API, will support it too.
Test
I added unit test to cover that change,
You can test this with the elastic_conector package (in prerelease)