Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Support input variable for integrations package #202362

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 29, 2024

Summary

Input variables used to not be available for integrations package, it seems the support for the UI editor is already done probably with #194310

That PR add the support so the package API, will support it too.

Test

I added unit test to cover that change,

You can test this with the elastic_conector package (in prerelease)

POST kbn:/api/fleet/package_policies
{
  "package": {
    "name": "elastic_connectors",
    "version": "0.0.4"
  },
  "name": "elastic_connectors-2",
  "namespace": "",
  "description": "",
  "policy_ids": [
    "fleet-server-policy"
  ],
  "vars": {},
  "inputs": {
    "github-connectors-py": {
      "enabled": true,
      "vars": {
        "connector_name": "my-test-connector",
        "connector_id": "123456"
      },
      "streams": {}
    },
    "google_drive-connectors-py": {
      "enabled": true,
      "vars": {
        "connector_name": "test",
        "connector_id": "tata"
      },
      "streams": {}
    }
  }
}

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 29, 2024
@nchaulet nchaulet self-assigned this Nov 29, 2024
@nchaulet nchaulet added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Nov 29, 2024
@nchaulet nchaulet marked this pull request as ready for review November 29, 2024 20:31
@nchaulet nchaulet requested a review from a team as a code owner November 29, 2024 20:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #103 / Solution navigation smoke tests search solution sidenav & breadcrumbs renders the correct nav and navigate to links

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 173.4KB 173.4KB -4.0B

History

cc @nchaulet

@nchaulet nchaulet merged commit f21fdaf into elastic:main Dec 2, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12120093534

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 2, 2024
… (#202459)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Support input variable for integrations package
(#202362)](#202362)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T13:12:42Z","message":"[Fleet]
Support input variable for integrations package
(#202362)","sha":"f21fdaf563d9cfcbed2adb61f07346f96045136a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet]
Support input variable for integrations
package","number":202362,"url":"https://github.com/elastic/kibana/pull/202362","mergeCommit":{"message":"[Fleet]
Support input variable for integrations package
(#202362)","sha":"f21fdaf563d9cfcbed2adb61f07346f96045136a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202362","number":202362,"mergeCommit":{"message":"[Fleet]
Support input variable for integrations package
(#202362)","sha":"f21fdaf563d9cfcbed2adb61f07346f96045136a"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants