Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Suggestion to revise the statements.

Co-authored-by: João Duarte <[email protected]>
  • Loading branch information
mashhurs and jsvd authored Dec 2, 2024
1 parent 6820d47 commit 012a05d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/static/env-vars.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ environment variable is undefined.
* You can add environment variable references in any plugin option type: string, number, boolean, array, or hash.
* Environment variables for list-type URI parameters can support lists of space-delimited values. Currently, other non-URI based options do not support lists of values. See <<plugin-concepts>>
* Environment variables are immutable. If you update the environment variable, you'll have to restart Logstash to pick up the updated value.
* Environment variables in `config.string` comments are not allowed. Remove the `$` sign to avoid pipeline config failures.
* Environment variables references in `config.string` comments are not allowed. Remove the `$` sign to avoid pipeline config failures.

==== Examples

Expand Down
2 changes: 1 addition & 1 deletion docs/static/pipeline-configuration.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ input { # comments can appear at the end of a line, too
# ...
}
----------------------------------
NOTE: Due to a substitution logic, commenting environment `${var}` in `config.string` is not allowed. Remove the `$` sign to avoid pipeline config failures.
NOTE: Comments containing environment `${var}` references in `config.string` are not allowed. Remove the `$` sign to avoid pipeline loading failures.

include::event-data.asciidoc[]
include::env-vars.asciidoc[]
Expand Down

0 comments on commit 012a05d

Please sign in to comment.