Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #15514 to 8.11: Download of JDK from the Elastic catalog instead of Adoptium #15515

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport PR #15514 to 8.11 branch, original message:


Release notes

[rn:skip]

What does this PR do?

Adapted the JDK's download URL creation to intereact with Elastic catalog to get metadata, and return the catalog download link instead of directly pointing to Adoptium API

Why is it important/What is the impact to the user?

Let the CI work smoothly, using the unified source of JDKs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Use Gradle task:

./gradlew copyJdk -Pjdk_bundle_os=windows -Pjdk_arch=x86_64

using differn OSes (windows, linux, darwin) and different CPU architectures (x86_64,arm64).
arm64 is valid only for MacOS (Darwin).

Related issues

* Adapted the JDK's download URL creation to intereact with Elastic catalog to get metadata, and return the catalog download link instead of directly pointing to Adoptium API

* Silenced the Download task of JDK to print the full url

(cherry picked from commit 73daec0)
@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@andsel andsel self-assigned this Oct 30, 2023
@andsel andsel merged commit 47e0955 into 8.11 Oct 30, 2023
2 checks passed
@jsvd jsvd deleted the backport_15514_8.11 branch March 11, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants