Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed functional test in case the LS_JAVA_HOME is configured #15535

Merged

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Nov 7, 2023

Release notes

[rn:skip]

What does this PR do?

Adds filtering on Logstash output message in an integration tests when setting LS_JAVA_HOME environment variable.

Why is it important/What is the impact to the user?

As a developer I want to run integration tests customizing the JDK and not using the bundled one.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

export LS_JAVA_HOME=/path/to/JDK
./gradlew runIntegrationTests -PrubyIntegrationSpecs="specs/command_line_spec.rb"

Related issues

Use cases

Screenshots

Logs

@andsel andsel self-assigned this Nov 7, 2023
@andsel andsel force-pushed the fix/integration_tests_to_avoid_custom_JDK_warning branch from 1126cab to a413b6a Compare November 7, 2023 16:14
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andsel

Copy link
Contributor

@roaksoax roaksoax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andsel andsel merged commit 5af14f4 into elastic:main Nov 10, 2023
5 checks passed
@andsel
Copy link
Contributor Author

andsel commented Nov 10, 2023

@logstashmachine backport 8.11

github-actions bot pushed a commit that referenced this pull request Nov 10, 2023
Adds filtering on Logstash output message in an integration tests when setting LS_JAVA_HOME environment variable.

(cherry picked from commit 5af14f4)
@andsel
Copy link
Contributor Author

andsel commented Nov 10, 2023

@logstashmachine backport 7.17

andsel added a commit that referenced this pull request Nov 10, 2023
…#15558)

Adds filtering on Logstash output message in an integration tests when setting LS_JAVA_HOME environment variable.

(cherry picked from commit 5af14f4)

Co-authored-by: Andrea Selva <[email protected]>
@andsel
Copy link
Contributor Author

andsel commented Nov 10, 2023

@logstashmachine backport 7.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IT tests (part 1) failing when using a custom Java with LS_JAVA_HOME
3 participants