-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed functional test in case the LS_JAVA_HOME is configured #15535
Merged
andsel
merged 1 commit into
elastic:main
from
andsel:fix/integration_tests_to_avoid_custom_JDK_warning
Nov 10, 2023
Merged
Fixed functional test in case the LS_JAVA_HOME is configured #15535
andsel
merged 1 commit into
elastic:main
from
andsel:fix/integration_tests_to_avoid_custom_JDK_warning
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
force-pushed
the
fix/integration_tests_to_avoid_custom_JDK_warning
branch
from
November 7, 2023 16:14
1126cab
to
a413b6a
Compare
SonarQube Quality Gate |
💚 Build Succeeded
History
cc @andsel |
roaksoax
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
2 tasks
@logstashmachine backport 8.11 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
Adds filtering on Logstash output message in an integration tests when setting LS_JAVA_HOME environment variable. (cherry picked from commit 5af14f4)
Merged
2 tasks
@logstashmachine backport 7.17 |
andsel
added a commit
that referenced
this pull request
Nov 10, 2023
…#15558) Adds filtering on Logstash output message in an integration tests when setting LS_JAVA_HOME environment variable. (cherry picked from commit 5af14f4) Co-authored-by: Andrea Selva <[email protected]>
@logstashmachine backport 7.17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Adds filtering on Logstash output message in an integration tests when setting LS_JAVA_HOME environment variable.
Why is it important/What is the impact to the user?
As a developer I want to run integration tests customizing the JDK and not using the bundled one.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Related issues
LS_JAVA_HOME
#15529Use cases
Screenshots
Logs