[ci] Fix scheduled JDK matrix CI jobs #15623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dliappis
force-pushed
the
fix-logstash-jdk-matrix-scheduled-builds
branch
2 times, most recently
from
164fe7f to
6d07291
Compare
This commit fixes failed scheduled JDK matrix CI jobs, that can't access the default values for the OS and JDK from the input steps, as observed in [^1] and [^2]. [^1] https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/53#018c1371-b760-4c28-9203-340c0a1df150 [^2]: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/35#018c1371-b72e-48b4-b707-ce103eb6039c
dliappis
force-pushed
the
fix-logstash-jdk-matrix-scheduled-builds
branch
from
6d07291 to
162ae8c
Compare
This reverts commit c540971.
|
Because scheduled job testing is tricky, this is how this PR has been tested:
Linux: https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/55
Windows: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/41
The PR is now ready for review. I've reverted c540971 and we are back to the state described in 1. |
|
SonarQube Quality Gate
|
dliappis
commented
Nov 28, 2023
| @@ -1,5 +1,9 @@ | |||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json | |||
|
|
|||
| env: | |||
| DEFAULT_MATRIX_OS: "ubuntu-2204" | |||
| DEFAULT_MATRIX_JDK: "adoptiumjdk_17" | |||
There was a problem hiding this comment.
we discussed offline with @alexsapran who pointed out that another alternative for this would be to define it as env vars in the schedule branch section. In that case, the env vars here will always override any values in the schedule.
I think I prefer things as they are here, though, because we won't have different defaults per branch and will not need to define them in catalog-info.yaml and the source of truth for the defaults remains in the pipeline file.
💚 Build Succeeded
History
cc @dliappis |
alexsapran
approved these changes
Nov 28, 2023
|
@logstashmachine backport 8.11 |
|
@logstashmachine backport 7.17 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes failed scheduled JDK matrix CI jobs, that can't access the default values for the OS and JDK from the input steps, as observed in [^1] and [^2]. [^1] https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/53#018c1371-b760-4c28-9203-340c0a1df150 [^2]: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/35#018c1371-b72e-48b4-b707-ce103eb6039c (cherry picked from commit f0019bf)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes failed scheduled JDK matrix CI jobs, that can't access the default values for the OS and JDK from the input steps, as observed in [^1] and [^2]. [^1] https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/53#018c1371-b760-4c28-9203-340c0a1df150 [^2]: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/35#018c1371-b72e-48b4-b707-ce103eb6039c (cherry picked from commit f0019bf)
dliappis
added a commit
to dliappis/logstash
that referenced
this pull request
Nov 29, 2023
This commit fixes failed scheduled JDK matrix CI jobs, that can't access the default values for the OS and JDK from the input steps, as observed in [^1] and [^2]. [^1] https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/53#018c1371-b760-4c28-9203-340c0a1df150 [^2]: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/35#018c1371-b72e-48b4-b707-ce103eb6039c (cherry picked from commit f0019bf) Co-authored-by: Dimitrios Liappis <[email protected]>
jsvd
pushed a commit
to jsvd/logstash
that referenced
this pull request
Dec 5, 2023
This commit fixes failed scheduled JDK matrix CI jobs, that can't access the default values for the OS and JDK from the input steps, as observed in [^1] and [^2]. [^1] https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/53#018c1371-b760-4c28-9203-340c0a1df150 [^2]: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/35#018c1371-b72e-48b4-b707-ce103eb6039c (cherry picked from commit f0019bf) Co-authored-by: Dimitrios Liappis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
This commit fixes failed scheduled JDK matrix CI jobs, that can't access the default values for the OS and JDK from the input steps, as observed in [^1] and [^2].
[^1] https://buildkite.com/elastic/logstash-linux-jdk-matrix-pipeline/builds/53#018c1371-b760-4c28-9203-340c0a1df150 [^2]: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/35#018c1371-b72e-48b4-b707-ce103eb6039c
Related issues