Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add testing phase to exhaustive tests suite #15711

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Dec 20, 2023

Release notes

[rn:skip]

What does this PR do?

This is the second part of the migration of the exhaustive/main Jenkins Job to Buildkite. So far we've migrated the "compatibility phase" and this commit adds the "testing phase"[^1], which is essentially the same amount of tests that we ran on PR jobs.

For more details, refer to the sequence diagram in https://github.com/elastic/ingest-dev/issues/1722#issuecomment-1824378635

Why is it important/What is the impact to the user?

This runs the usual set of unit + IT tests in the exhaustive test pipeline, e.g. triggered by push events.

How to test this PR locally

See triggered BK job: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/41#_

Screenshots

Once triggered e.g. in this link in the structure looks like:

image

Related issues

This is the second part of the migration of the exhaustive/main
Jenkins Job to Buildkite. So far we've migrated the "compatibility
phase" and this commit adds the "testing phase"[^1], which is essentially
the same amount of tests that we ran on PR jobs.

Relates elastic/ingest-dev#1722

[^1]: For more details, refer to the sequence diagram in elastic/ingest-dev#1722 (comment)
@dliappis dliappis added the ci label Dec 20, 2023
@dliappis dliappis self-assigned this Dec 20, 2023
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@dliappis dliappis marked this pull request as ready for review December 20, 2023 16:46
@dliappis dliappis requested a review from robbavey December 20, 2023 16:46
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @dliappis

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the windows test permissions failures while attempting to run DLQ tests are unrelated to this change, LGTM

@dliappis
Copy link
Contributor Author

Assuming that the windows test permissions failures while attempting to run DLQ tests are unrelated to this change, LGTM

@robbavey yes it's unrelated as the Windows failure is in the Compatibility group, which we don't touch here.
For background, the test failure is known and logged in: #15562
and we can see it reproducing in other jobs too e.g. the Windows JDK matrix weekly: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/55#018c7f97-b89e-4a38-93fb-26b37f7bd9af
Downloading the build_reports.zip artifact, we can confirm it's the same issue:

image

We are currently missing collecting the failure report in the compat job of this suite (which we do in the JDK matrix ones as I said above), so I'll tackle this unrelated issue in a follow up PR.

@dliappis dliappis merged commit 9538338 into elastic:main Dec 21, 2023
5 checks passed
@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.12

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.11

@dliappis
Copy link
Contributor Author

@logstashmachine backport 7.17

github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
This is the second part of the migration of the exhaustive/main
Jenkins Job to Buildkite. So far we've migrated the "compatibility
phase" and this commit adds the "testing phase"[^1], which is essentially
the same amount of tests that we ran on PR jobs.

Relates elastic/ingest-dev#1722
Depends #15708

[^1]: For more details, refer to the sequence diagram in elastic/ingest-dev#1722 (comment)

(cherry picked from commit 9538338)
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
This is the second part of the migration of the exhaustive/main
Jenkins Job to Buildkite. So far we've migrated the "compatibility
phase" and this commit adds the "testing phase"[^1], which is essentially
the same amount of tests that we ran on PR jobs.

Relates elastic/ingest-dev#1722
Depends #15708

[^1]: For more details, refer to the sequence diagram in elastic/ingest-dev#1722 (comment)

(cherry picked from commit 9538338)
github-actions bot pushed a commit that referenced this pull request Dec 21, 2023
This is the second part of the migration of the exhaustive/main
Jenkins Job to Buildkite. So far we've migrated the "compatibility
phase" and this commit adds the "testing phase"[^1], which is essentially
the same amount of tests that we ran on PR jobs.

Relates elastic/ingest-dev#1722
Depends #15708

[^1]: For more details, refer to the sequence diagram in elastic/ingest-dev#1722 (comment)

(cherry picked from commit 9538338)
dliappis added a commit that referenced this pull request Dec 21, 2023
This is the second part of the migration of the exhaustive/main
Jenkins Job to Buildkite. So far we've migrated the "compatibility
phase" and this commit adds the "testing phase"[^1], which is essentially
the same amount of tests that we ran on PR jobs.

Relates elastic/ingest-dev#1722
Depends #15708

[^1]: For more details, refer to the sequence diagram in elastic/ingest-dev#1722 (comment)

(cherry picked from commit 9538338)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Dec 21, 2023
This is the second part of the migration of the exhaustive/main
Jenkins Job to Buildkite. So far we've migrated the "compatibility
phase" and this commit adds the "testing phase"[^1], which is essentially
the same amount of tests that we ran on PR jobs.

Relates elastic/ingest-dev#1722
Depends #15708

[^1]: For more details, refer to the sequence diagram in elastic/ingest-dev#1722 (comment)

(cherry picked from commit 9538338)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Dec 21, 2023
This is the second part of the migration of the exhaustive/main
Jenkins Job to Buildkite. So far we've migrated the "compatibility
phase" and this commit adds the "testing phase"[^1], which is essentially
the same amount of tests that we ran on PR jobs.

Relates elastic/ingest-dev#1722
Depends #15708

[^1]: For more details, refer to the sequence diagram in elastic/ingest-dev#1722 (comment)

(cherry picked from commit 9538338)

Co-authored-by: Dimitrios Liappis <[email protected]>
mgreau added a commit that referenced this pull request Dec 21, 2023
* 8.11:
  [ci] Add testing phase to exhaustive tests suite (#15711) (#15717)
  [ci] Reusable unit + IT test steps for Buildkite (#15708) (#15714)
  Remove temporary dependencies in logstash-core.gemspec (#15694)
  Release notes for 8.11.3 (#15681)
  bump version to 8.11.4 (#15682)
  Doc: Add docs for extending integrations with filter-elastic_integrations (#15518) (#15675)
  Update JRuby to 9.4.5.0 (#15531) (#15670)
  bump to 8.11.3 (#15669)
  Release notes for 8.11.2 (#15660)
  Doc: Update Logstash intro and security overview for serverless (#15313) (#15664)
  Shutdown DLQ segments flusher only if it has been started (#15649) (#15656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants