JDK 21 move #15719
Merged
JDK 21 move #15719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
commented
Dec 21, 2023
Comment on lines
34
to
35
| project.sourceCompatibility = JavaVersion.VERSION_11 | ||
| project.targetCompatibility = JavaVersion.VERSION_11 |
There was a problem hiding this comment.
Note for reviewer
Running Gradle 8.5 with JDK 21 with
./gradlew :jvm-options-parser:compileJavatrigger the error:
> Task :jvm-options-parser:compileJava FAILED
warning: [options] source value 8 is obsolete and will be removed in a future release
warning: [options] target value 8 is obsolete and will be removed in a future release
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
error: warnings found and -Werror specified
FAILURE: Build failed with an exception.
Java 8 is obsolete and its support will be dropped
6 tasks
|
100.0% Coverage on New Code
0.0% Duplication on New Code
andsel
force-pushed
the
fix/jdk21_move
branch
2 times, most recently
from
4561669 to
7904dc9
Compare
|
As reported in Oracle blog, a new |
|
…vor of threadId()
…g is a false positive
6 tasks
mashhurs
reviewed
Apr 2, 2024
jsvd
approved these changes
Apr 3, 2024
jsvd
reviewed
Apr 3, 2024
lib/bootstrap/rspec.rb
Outdated
| # It's mainly related to Gradle opening java.base module and this interfere with | ||
| # JRuby binding of methods. Full description at https://github.com/jruby/jruby/issues/8061#issuecomment-1908807511 | ||
| # Remove when Logstash bundle a JRuby version >= 9.4.6.0. | ||
| java.util.LinkedHashSet.remove_method(:map) rescue nil |
There was a problem hiding this comment.
Actually now that main and 8.13 are on JRuby 9.4.6.0 we should be able to remove this.
jsvd
reviewed
Apr 3, 2024
Given that Logstash already ships with JRuby 9.4.6.0 which contains the fix jruby/jruby#8061, the workaround to avoid the original bad param numbers can be removed.
|
💚 Build Succeeded
History
cc @andsel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Adaptations to run Logstash on JDK 21
What does this PR do?
Adaptations to JDK 21:
getId(not final) replaced by finalthreadIdhttps://bugs.openjdk.org/browse/JDK-8017617thisreference to other methods https://bugs.openjdk.org/browse/JDK-8015831<uri_instance>.toURL()(since JDK 20)G1 Concurrent GCMX Bean, refWhy is it important/What is the impact to the user?
As a developer I want that all the blockings to use JDK 21 are removed before effectively switching the bundled JDK to version 21
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
How to test this PR locally
Install a JDK 21 on your host, example:
and run some testing, like
./gradlew runIntegrationTests -PrubyIntegrationSpecs="specs/mixed_codec_spec.rb" --console=plainor if you would run all integration tests:
try also a run of Logstash with
LS_JAVA_HOMEset to a JDK 21 path.Related issues
Use cases
Screenshots
Logs