Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #15738 to 8.11: Run BK exhaustive pipeline when code is pushed #15771

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Jan 10, 2024

Backport PR #15738 to 8.11 branch, original message:


Release notes

[rn:skip]

What does this PR do?

As we are close to sunsetting Jenkins by completing the exhaustive tests Buildkite pipeline, it makes sense to start already running the existing phases (testing and compatibility).

This commit defines the trigger to be code events, i.e. direct pushes and merge commits, similar to what we currently have in Jenkins.

Why is it important/What is the impact to the user?

It allows us to gradually remove the corresponding phases from Jenkins to reduce CI duplication.
This will be especially useful when merging #15696 as the change is incompatible with Jenkins.

How to test this PR locally

An example build triggered manually can be found in https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/49#_
Unfortunately Windows tests will fail due to #15562

Related issues

This commit enables running the exhaustive tests Buildkite pipeline
(i.e. the equivalent to the `main` Jenkins tests) ; the trigger is
code events, i.e. direct pushes, merge commits and creation of new branches.

CI is skipped if changes are only related to files under `docs/`.
@dliappis dliappis self-assigned this Jan 10, 2024
@dliappis dliappis changed the title Run BK exhaustive pipeline when code is pushed (#15738) Backport PR #15738 to 8.11: Run BK exhaustive pipeline when code is pushed (#15738) Jan 10, 2024
@dliappis dliappis changed the title Backport PR #15738 to 8.11: Run BK exhaustive pipeline when code is pushed (#15738) Backport PR #15738 to 8.11: Run BK exhaustive pipeline when code is pushed Jan 10, 2024
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @dliappis

Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dliappis
Copy link
Contributor Author

Why in PR #15770 there is a change to the catalog-info.yaml which is not present here?

https://github.com/elastic/logstash/pull/15770/files#diff-47e4499e7f2830df90da07ca1636ba625c6a700eedc9671dfc2f7ca69fed42fe

@andsel catalog-info.yaml is a file consulted by internal Buildkite tooling only from the main branch. In newer branches, like 8.12, which were cut at a later date the file is identical to main, whereas in older ones the file either doesn't exist (e.g. in 7.17) or is outdated (like here) therefore there is no value in backporting.

Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis dliappis merged commit f769651 into elastic:8.11 Jan 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants