Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split java/ruby unit test steps on Windows #15888

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Feb 1, 2024

Release notes

[rn:skip]

What does this PR do?

As a follow up to #15861 this commit splits the current unit tests step for the Windows JDK matrix pipeline to two that run Java and Ruby unit tests separately.

How to test this PR locally

Test runs in Buildkite:

Related issues

As a follow up to elastic#15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes elastic#15566
@dliappis
Copy link
Contributor Author

dliappis commented Feb 2, 2024

Blocked by #15890

@dliappis
Copy link
Contributor Author

dliappis commented Mar 6, 2024

I merged the fix for #15890 in this PR and triggered a test run in https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/123#_ to verify the fix.

@dliappis
Copy link
Contributor Author

dliappis commented Mar 7, 2024

Now that the fix for the blocker has been merged, I merged main again in this PR and did a final BK re-run that verifies everything's ok: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/124

@dliappis dliappis requested a review from mashhurs March 7, 2024 07:46
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @dliappis

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dliappis dliappis merged commit c0c213d into elastic:main Mar 11, 2024
5 checks passed
@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.13

@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.12

@dliappis
Copy link
Contributor Author

@logstashmachine backport 7.17

github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)
dliappis added a commit that referenced this pull request Mar 11, 2024
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Mar 11, 2024
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this pull request Mar 11, 2024
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)

Co-authored-by: Dimitrios Liappis <[email protected]>
@dliappis dliappis added the tests label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Windows CI JDK Matrix job to Java and Ruby
4 participants