Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ES output to include unicode-vs-compression fix #16012

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Mar 20, 2024

Release notes

Updates the Elasticsearch output to include a fix for situations where events containing non-unicode strings could be serialized incorrectly when sending to Elasticsearch with http compression enabled

What does this PR do?

Updates ES output to consume logstash-plugins/logstash-output-elasticsearch#1171

Why is it important/What is the impact to the user?

When compression is enabled and events contain non-unicode characters, without this fix invalid payloads could be sent to Elasticsearch resulting in indexing rejections.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

Use cases

  • ES Output with http compression enabled

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@mashhurs mashhurs merged commit fa3973d into 7.17 Mar 20, 2024
4 checks passed
@mashhurs mashhurs deleted the yaauie-compressed-unicode-es-output branch March 20, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants