Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github checkout for critical_vulnerability_scan action #16039

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Mar 28, 2024

Change trigger from pull_request_target to pull_request, as the former uses the base branch instead of the PR source code. This allows simplification of the checkout action (also took the opportunity to bump from v2 to v4).

Change trigger from pull_request_target to pull_request, as the former uses the base branch instead of the PR source code.
This allows simplification of the checkout action (also took the opportunity to bump from v2 to v4).
@jsvd jsvd changed the title Update critical_vulnerability_scan.yml Fix github checkout for critical_vulnerability_scan action Mar 28, 2024
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsvd jsvd merged commit f6940f5 into elastic:main Mar 28, 2024
6 of 7 checks passed
@jsvd jsvd deleted the jsvd-patch-2 branch March 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants