Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop JDK 11 support #16443

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Drop JDK 11 support #16443

merged 6 commits into from
Sep 13, 2024

Conversation

andsel
Copy link
Contributor

@andsel andsel commented Sep 12, 2024

Release notes

Remove support for JDK 11

What does this PR do?

Updates the jvm.options and JvmOptionsParser to remove support for JDK 11. If the options parser identifies that the running JVM is less than 17, it refuses to start.

Why is it important/What is the impact to the user?

If a user runs Logstash with a hosted JDK and not the one bundled with Logstash distribution, like setting a specific LS_JAVA_HOME, which is minor than JDK 17 then Logstash refuses to start. Has to provide at least a JDK 17 or unset the LS_JAVA_HOME and let Logstash uses the bundled JDK.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • try with sdkman and a JDK 11

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config/jvm.options Outdated Show resolved Hide resolved
logstash-core/locales/en.yml Outdated Show resolved Hide resolved
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks, otherwise LGTM

Co-authored-by: João Duarte <[email protected]>
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andsel

@andsel andsel merged commit 1ec37b7 into elastic:main Sep 13, 2024
7 checks passed
@andsel andsel linked an issue Sep 13, 2024 that may be closed by this pull request
@andsel andsel mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up jvm.options
3 participants