-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove http.* settings #16552
Merged
Merged
remove http.* settings #16552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd http.environment
kaisecheng
force-pushed
the
obsolete_http_settings
branch
from
October 17, 2024 13:37
498698c
to
62d81f4
Compare
Seems like there are still a few references to
|
@jsvd good catch! |
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
|
jsvd
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Removed the deprecated settings
http.port
,http.host
,http.enabled
, andhttp.environment
. Please useapi.http.port
,api.http.host
,api.http.enabled
, andapi.http.environment
instead.What does this PR do?
The commit removes the deprecated settings
http.port
,http.host
,http.enabled
, andhttp.environment
.Why is it important/What is the impact to the user?
Checklist
Author's Checklist
bin/logstash -e "input { stdin {} } output { stdout {} }" --http.enabled false
gives "ERROR: Unrecognised option '--http.enabled'"How to test this PR locally
Related issues
Use cases
Screenshots
Logs