skip allow_superuser in Windows OS
#16629
Conversation
As euid() is always zero in Windows, this commit excluded the checking of running as root in Windows.
|
💚 Build Succeeded
History
|
|
windows buildkite is green |
| @@ -320,7 +320,7 @@ | |||
| # | |||
| # ------------ Other Settings -------------- | |||
| # | |||
| # Allow or block running Logstash as superuser (default: true) | |||
| # Allow or block running Logstash as superuser (default: true). Windows are excluded from the checking | |||
| # allow_superuser: false | |||
There was a problem hiding this comment.
Did we agree that we are not going to support this feature on Windows?
There was a problem hiding this comment.
If there is a desire to generally determine if a process is running as an admin or with elevated status on windows there is a pattern in Puppet for doing so https://github.com/puppetlabs/puppet/blob/e758d5c969403631810fa6385057ef0eaf03974f/lib/puppet/util/windows/user.rb#L11 though it is fairly complex and carries a dependency on ffi which requires native extensions.
There was a problem hiding this comment.
@mashhurs My goal here is to unblock the exhaustive test, not to bring the feature to windows
I believe it is another PR to fix the original handling
There was a problem hiding this comment.
follow up issue to fix windows handling #16632
kaisecheng
changed the title
allow_superuser in Windows OSallow_superuser in Windows OS
Release notes
[rn:skip]
What does this PR do?
As Process.euid() is always zero in Windows,
this commit excluded the checking of running as root in Windows.
Why is it important/What is the impact to the user?
Checklist
Author's Checklist
How to test this PR locally
Related issues
allow_superuserto false as default #16558Use cases
Screenshots
Logs