-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add breaking changes docs for input-elasticsearch #16744
Add breaking changes docs for input-elasticsearch #16744
Conversation
📃 DOCS PREVIEW ✨ https://logstash_bk_16744.docs-preview.app.elstc.co/diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ordering nits
==== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe put these before the HTTP output - I think it might make sense to order these alphabetically
(cc @karenzone)
[cols="<,<",options="header",] | ||
|======================================================================= | ||
|Setting|Replaced by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want these in alphabetical order?
This commit follows the pattern established in elastic#16701 for indicating obsolete ssl settings in logstash core plugins.
d3f1645
to
f54f9ff
Compare
📃 DOCS PREVIEW ✨ https://logstash_bk_16744.docs-preview.app.elstc.co/diff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Release notes
[rn:skip]
What does this PR do?
This commit follows the pattern established in #16701 for indicating obsolete ssl settings in logstash core plugins.