Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking changes docs for input-elasticsearch #16744

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Dec 2, 2024

Release notes

[rn:skip]

What does this PR do?

This commit follows the pattern established in #16701 for indicating obsolete ssl settings in logstash core plugins.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

📃 DOCS PREVIEWhttps://logstash_bk_16744.docs-preview.app.elstc.co/diff

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordering nits

====
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put these before the HTTP output - I think it might make sense to order these alphabetically

(cc @karenzone)

[cols="<,<",options="header",]
|=======================================================================
|Setting|Replaced by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want these in alphabetical order?

@robbavey robbavey requested a review from karenzone December 3, 2024 14:51
This commit follows the pattern established in
elastic#16701 for indicating obsolete ssl
settings in logstash core plugins.
@donoghuc donoghuc force-pushed the ssl-obsolete-input-elasticsearch branch from d3f1645 to f54f9ff Compare December 3, 2024 18:02
Copy link
Contributor

github-actions bot commented Dec 3, 2024

📃 DOCS PREVIEWhttps://logstash_bk_16744.docs-preview.app.elstc.co/diff

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@donoghuc donoghuc merged commit 095fbbb into elastic:main Dec 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants