Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of beats-input obsoleted SSL params in the core. #16753

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mashhurs
Copy link
Contributor

@mashhurs mashhurs commented Dec 4, 2024

Release notes

[rn:skip]

What does this PR do?

Recently, some of SSL params of beats-input obsoleted. We need update usage of those params which this PR does.

Why is it important/What is the impact to the user?

N.A

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

github-actions bot commented Dec 4, 2024

📃 DOCS PREVIEWhttps://logstash_bk_16753.docs-preview.app.elstc.co/diff

@mashhurs
Copy link
Contributor Author

mashhurs commented Dec 4, 2024

Failed tests are not due to this change. Somehow LS is consuming two versions of date gem and getting warning when running Logstash main:

WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
      date (>= 0)
      Available/installed versions of this gem:
      - 3.4.1
      - 3.3.3
WARN: Clearing out unresolved specs. Try 'gem cleanup <gem>'
Please report a bug if this causes problems.

@donoghuc
Copy link
Member

donoghuc commented Dec 4, 2024

I think this is coming from psych pushing a release that explicitly requires any version of date. date is a standard gem (ships with both jruby and mri). Bundler does not consider default gems and will just try to get the latest. So what happens is bundler will get the latest date then when the psych is loaded we get a warning about ambiguous versions (3.3.3 is the version in our jruby and 3.4.1 is the latest version on rubygems).

This is a similar issue to what we were seeing with jar-dependnecies i think. Perhaps we should find all the deps that are default gems and coordinate them with the jruby version we are shipping at any time by pinning to those versions.

See ruby/psych@b2aa003

@mashhurs mashhurs requested a review from donoghuc December 4, 2024 19:11
Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed we will address the ambiguous gem loading separately. This looks complete to get tests passing again. 👍

@mashhurs mashhurs merged commit 4d9942d into elastic:main Dec 4, 2024
6 of 7 checks passed
@mashhurs mashhurs deleted the update-ssl-values-of-beats-input branch December 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants