Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin plugins that incorporate breaking changes in 9.0 #16759

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

robbavey
Copy link
Member

@robbavey robbavey commented Dec 5, 2024

A number of plugins include breaking changes in 9.x, which, without restriction, will be included in development 8.x branches that do not include a lockfile.

This commit adds these to the Gemfile.template to avoid being introduced in 8.x development branches

Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The failures appear to be due to #16761

A number of plugins include breaking changes in 9.x, which, without
restriction, will be included in development `8.x` branches that do
not include a lockfile.

This commit adds these to the Gemfile.template to avoid being introduced
in 8.x development branches
@robbavey robbavey force-pushed the add_plugin_restrictions branch from c4e0ca5 to a5f5d98 Compare December 5, 2024 20:56
@robbavey robbavey merged commit 1d82e37 into elastic:8.x Dec 5, 2024
2 of 3 checks passed
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants