-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update serverless tests to include product origin header #16766
Update serverless tests to include product origin header #16766
Conversation
cc @jsvd, @kaisecheng |
I don't think we'll have much success in knowing the outcome of this effort given we can't see serverless' logs from the management page. But otherwise this was indeed the goal. @kaisecheng can we trigger the serverless testing bk pipeline using this branch? |
aa407ae
to
03972e4
Compare
03972e4
to
22de950
Compare
I triggered buildkite job for this pr It is green :) need to add the header to other eg. CPM, es-integration-filter, es-output... |
@kaisecheng I believe all of the places we need to add these should have been captured in https://github.com/elastic/ingest-dev/issues/4279 and https://github.com/elastic/ingest-dev/issues/4278. If you see a place that we have missed, please update these issues and let me know. |
@robbavey The serverless tests call API of CPM , _ingest pipeline and _count, which should add the header. Plugins are fine. |
Gotcha. Thank you @kaisecheng! |
I can add headers to those as part of this PR. Thanks! |
This commit updates the curl scripts that interact with Kibana's `api/logstash/pipeline/*` endpoin. Additionally this adds the header to any curl that interacts with elasticsearch API as well.
22de950
to
9e314ea
Compare
Updated all interaction i saw with ES and Kibana. Kicked off a build of serverless tests: https://buildkite.com/elastic/logstash-serverless-integration-testing/builds/595 Will keep an eye on the status of that build. |
Quality Gate passedIssues Measures |
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like https://buildkite.com/elastic/logstash-serverless-integration-testing/builds/595 went green. Thanks for the help! |
@logstashmachine backport 8.x |
This commit updates the curl scripts that interact with Kibana's `api/logstash/pipeline/*` endpoin. Additionally this adds the header to any curl that interacts with elasticsearch API as well. (cherry picked from commit 188d9e7)
…6797) This commit updates the curl scripts that interact with Kibana's `api/logstash/pipeline/*` endpoin. Additionally this adds the header to any curl that interacts with elasticsearch API as well. (cherry picked from commit 188d9e7) Co-authored-by: Cas Donoghue <[email protected]>
Release notes
[rn:skip]
What does this PR do?
This commit updates the curl scripts that interact with Kibana's
api/logstash/pipeline/*
endpoints.