Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serverless tests to include product origin header #16766

Conversation

donoghuc
Copy link
Member

@donoghuc donoghuc commented Dec 6, 2024

Release notes

[rn:skip]

What does this PR do?

This commit updates the curl scripts that interact with Kibana's
api/logstash/pipeline/* endpoints.

@robbavey
Copy link
Member

robbavey commented Dec 9, 2024

cc @jsvd, @kaisecheng

@jsvd
Copy link
Member

jsvd commented Dec 11, 2024

I don't think we'll have much success in knowing the outcome of this effort given we can't see serverless' logs from the management page. But otherwise this was indeed the goal. @kaisecheng can we trigger the serverless testing bk pipeline using this branch?

@donoghuc donoghuc force-pushed the GH-16736-update-serverless-tests-product-origin branch from aa407ae to 03972e4 Compare December 11, 2024 19:10
@donoghuc donoghuc changed the title WIP: Double check understanding Update serverless tests to include product origin header Dec 11, 2024
@donoghuc donoghuc force-pushed the GH-16736-update-serverless-tests-product-origin branch from 03972e4 to 22de950 Compare December 11, 2024 19:15
@donoghuc donoghuc marked this pull request as ready for review December 11, 2024 19:15
@kaisecheng
Copy link
Contributor

I triggered buildkite job for this pr
Screenshot 2024-12-12 at 11 23 10

It is green :) need to add the header to other eg. CPM, es-integration-filter, es-output...

@robbavey
Copy link
Member

It is green :) need to add the header to other eg. CPM, es-integration-filter, es-output...

@kaisecheng I believe all of the places we need to add these should have been captured in https://github.com/elastic/ingest-dev/issues/4279 and https://github.com/elastic/ingest-dev/issues/4278.

If you see a place that we have missed, please update these issues and let me know.

@kaisecheng
Copy link
Contributor

@robbavey The serverless tests call API of CPM , _ingest pipeline and _count, which should add the header.

Plugins are fine.

@robbavey
Copy link
Member

Gotcha. Thank you @kaisecheng!

@donoghuc
Copy link
Member Author

I can add headers to those as part of this PR. Thanks!

This commit updates the curl scripts that interact with Kibana's
`api/logstash/pipeline/*` endpoin. Additionally this adds the header to any curl
that interacts with elasticsearch API as well.
@donoghuc donoghuc force-pushed the GH-16736-update-serverless-tests-product-origin branch from 22de950 to 9e314ea Compare December 13, 2024 00:05
@donoghuc
Copy link
Member Author

Updated all interaction i saw with ES and Kibana. Kicked off a build of serverless tests: https://buildkite.com/elastic/logstash-serverless-integration-testing/builds/595 Will keep an eye on the status of that build.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donoghuc
Copy link
Member Author

Looks like https://buildkite.com/elastic/logstash-serverless-integration-testing/builds/595 went green. Thanks for the help!

@donoghuc donoghuc merged commit 188d9e7 into elastic:main Dec 13, 2024
6 checks passed
@donoghuc
Copy link
Member Author

@logstashmachine backport 8.x

github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
This commit updates the curl scripts that interact with Kibana's
`api/logstash/pipeline/*` endpoin. Additionally this adds the header to any curl
that interacts with elasticsearch API as well.

(cherry picked from commit 188d9e7)
donoghuc added a commit that referenced this pull request Dec 13, 2024
…6797)

This commit updates the curl scripts that interact with Kibana's
`api/logstash/pipeline/*` endpoin. Additionally this adds the header to any curl
that interacts with elasticsearch API as well.

(cherry picked from commit 188d9e7)

Co-authored-by: Cas Donoghue <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants