Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] remove modules #16796

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Doc] remove modules #16796

wants to merge 2 commits into from
+1 −1,639

Conversation

kaisecheng
Copy link
Contributor

@kaisecheng kaisecheng commented Dec 13, 2024 •
edited
Loading

Remove all module related doc

@kaisecheng kaisecheng changed the title [Docremove modules doc [Doc] remove modules Dec 13, 2024
@kaisecheng kaisecheng linked an issue Dec 13, 2024 that may be closed by this pull request
Remove the Arcsight module from x-pack #16740
Closed
kaisecheng
kaisecheng commented Dec 13, 2024
View reviewed changes
docs/static/deploying.asciidoc
@@ -180,9 +180,7 @@ with the <<plugins-codecs-netflow,Netflow codec>>.
<<plugins-codecs-nmap,Nmap codec>>.
* SNMP trap - Logstash has a native <<plugins-inputs-snmptrap,SNMP trap input>>.
* CEF - Logstash accepts and parses CEF data from systems like Arcsight
SmartConnectors with the <<plugins-codecs-cef,CEF codec>>. See this
https://www.elastic.co/blog/integrating-elastic-stack-with-arcsight-siem-part-1[blog series]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the link to module blog post

@kaisecheng kaisecheng mentioned this pull request Dec 13, 2024
Merged
10 tasks
@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_16796.docs-preview.app.elstc.co/diff

@robbavey
Copy link
Member

Let's work on this one with @karenzone before committing this removal - there are likely places where we will want to add placeholders to help users coming from previous documentation, and pointers to other elastic solutions to provide equivalent functionality

@karenzone
Copy link
Contributor

karenzone commented Dec 16, 2024 •
edited
Loading

Let's work on this one with @karenzone before committing this removal - there are likely places where we will want to add placeholders to help users coming from previous documentation, and pointers to other elastic solutions to provide equivalent functionality

Yes, please. This is not how we handle doc removals. I have two related issues to handle:

karenzone
karenzone requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs require a different approach. Please don't merge.

@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_16796.docs-preview.app.elstc.co/diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the Arcsight module from x-pack
3 participants
@kaisecheng @robbavey @karenzone