Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling 8.10 updates #3234

Merged
merged 22 commits into from
Sep 19, 2023
Merged

Profiling 8.10 updates #3234

merged 22 commits into from
Sep 19, 2023

Conversation

iogbole
Copy link
Contributor

@iogbole iogbole commented Sep 14, 2023

No description provided.

@iogbole iogbole requested a review from a team as a code owner September 14, 2023 18:51
@github-actions
Copy link
Contributor

A documentation preview will be available soon:

@iogbole iogbole added the backport-8.10 Automated backport with mergify label Sep 14, 2023
@iogbole iogbole requested a review from inge4pres September 14, 2023 20:25
. Setup Universal Profiling from scratch
. Start profiling data ingestion

To upgrade from version 8.10 or later, you need to:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first step here should be:

. Stop profiling data ingestion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we suggest to stop ingestion?
If our data model will always be backward compatible, there is no need to stop ingesting data, as the new replicas will push the new version (maybe with additional doc fileds?) while the others will keep sending the old data.

Are you saying that we have strict mapping that does not allow adding fields?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this because the last step that was mentioned was to start profiling data ingestion. So we either have to add this step or remove the step to start data ingestion.

@@ -1,8 +1,7 @@
[[universal-profiling]]
= Universal Profiling


Elastic Universal Profiling is a continuous profiling tool running on top of the {stack}. For a quick overview of Universal Profiling, see the https://www.elastic.co/observability/ebpf-continuous-code-profiling[Universal Profiling product page].
Elastic Universal Profiling is a whole-system, always-on, continuous profiling solution that eliminates the need for code instrumentation, recompilation, on-host debug symbols and service restarts. Leveraging eBPF, Universal Profiling operates within the Linux kernel space, capturing only the needed data with minimal overhead in an unobtrusive manner. For a quick overview of Universal Profiling, see the https://www.elastic.co/observability/ebpf-continuous-code-profiling[Universal Profiling product page].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a double-space between the 2 sentences? . For`

Suggested change
Elastic Universal Profiling is a whole-system, always-on, continuous profiling solution that eliminates the need for code instrumentation, recompilation, on-host debug symbols and service restarts. Leveraging eBPF, Universal Profiling operates within the Linux kernel space, capturing only the needed data with minimal overhead in an unobtrusive manner. For a quick overview of Universal Profiling, see the https://www.elastic.co/observability/ebpf-continuous-code-profiling[Universal Profiling product page].
Elastic Universal Profiling is a whole-system, always-on, continuous profiling solution that eliminates the need for code instrumentation, recompilation, on-host debug symbols and service restarts. Leveraging eBPF, Universal Profiling operates within the Linux kernel space, capturing only the needed data with minimal overhead in an unobtrusive manner. For a quick overview of Universal Profiling, see the https://www.elastic.co/observability/ebpf-continuous-code-profiling[Universal Profiling product page].

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes but otherwise LGTM!

docs/en/observability/universal-profiling.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/universal-profiling.asciidoc Outdated Show resolved Hide resolved
docs/en/observability/universal-profiling.asciidoc Outdated Show resolved Hide resolved
@iogbole iogbole requested a review from inge4pres September 19, 2023 09:56
@iogbole iogbole merged commit f189ecb into main Sep 19, 2023
2 checks passed
@iogbole iogbole deleted the profiling-update-810 branch September 19, 2023 14:34
mergify bot pushed a commit that referenced this pull request Sep 19, 2023
updated contents and images

(cherry picked from commit f189ecb)
iogbole added a commit that referenced this pull request Sep 19, 2023
updated contents and images

(cherry picked from commit f189ecb)

Co-authored-by: Israel Ogbole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.10 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants