[synthetics] Update docs to reflect the changes to expect
#3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A documentation preview will be available soon: |
vigneshshanmugam
previously approved these changes
Oct 18, 2023
colleenmcginnis
commented
Oct 19, 2023
vigneshshanmugam
approved these changes
Oct 19, 2023
bmorelli25
approved these changes
Oct 19, 2023
colleenmcginnis
added a commit
that referenced
this pull request
Oct 19, 2023
…3301) * first draft switch to playwright expect * adjust based on release notes * clarify what's not supported (cherry picked from commit a3e45c0) Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3206
Currently the docs list the supported Jest
expectmethods. As of @elastic/synthetics v1.5.0, we use Playwright Testexpectassertions. This replaces the list of supported Jest methods with links to the Playwright assertion docs.👋 @vigneshshanmugam I'm not sure if I've captured everything correctly.
cc @paulb-elastic