-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete templates/ILM on profiling upgrade #3298
Merged
danielmitterdorfer
merged 2 commits into
elastic:main
from
danielmitterdorfer:delete-templates
Oct 23, 2023
Merged
Delete templates/ILM on profiling upgrade #3298
danielmitterdorfer
merged 2 commits into
elastic:main
from
danielmitterdorfer:delete-templates
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we amend the instructions to delete data on profiling upgrade (only required for pre-GA versions) to also include deletion of index templates, component templates and the ILM policy. This ensures a smooth upgrade without any leftovers.
danielmitterdorfer
added
Profiling
v8.12.0
backport-8.10
Automated backport with mergify
backport-8.11
Automated backport with mergify
labels
Oct 19, 2023
A documentation preview will be available soon: |
mdbirnstiehl
previously approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion, but LGTM
Co-authored-by: Mike Birnstiehl <[email protected]>
mdbirnstiehl
approved these changes
Oct 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
With this commit we amend the instructions to delete data on profiling upgrade (only required for pre-GA versions) to also include deletion of index templates, component templates and the ILM policy. This ensures a smooth upgrade without any leftovers. Co-authored-by: Mike Birnstiehl <[email protected]> --------- Co-authored-by: Mike Birnstiehl <[email protected]> (cherry picked from commit 999b1ff)
mergify bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
With this commit we amend the instructions to delete data on profiling upgrade (only required for pre-GA versions) to also include deletion of index templates, component templates and the ILM policy. This ensures a smooth upgrade without any leftovers. Co-authored-by: Mike Birnstiehl <[email protected]> --------- Co-authored-by: Mike Birnstiehl <[email protected]> (cherry picked from commit 999b1ff)
danielmitterdorfer
added a commit
that referenced
this pull request
Oct 24, 2023
With this commit we amend the instructions to delete data on profiling upgrade (only required for pre-GA versions) to also include deletion of index templates, component templates and the ILM policy. This ensures a smooth upgrade without any leftovers. Co-authored-by: Mike Birnstiehl <[email protected]> --------- Co-authored-by: Mike Birnstiehl <[email protected]> (cherry picked from commit 999b1ff) Co-authored-by: Daniel Mitterdorfer <[email protected]>
danielmitterdorfer
added a commit
that referenced
this pull request
Oct 24, 2023
With this commit we amend the instructions to delete data on profiling upgrade (only required for pre-GA versions) to also include deletion of index templates, component templates and the ILM policy. This ensures a smooth upgrade without any leftovers. Co-authored-by: Mike Birnstiehl <[email protected]> --------- Co-authored-by: Mike Birnstiehl <[email protected]> (cherry picked from commit 999b1ff) Co-authored-by: Daniel Mitterdorfer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.10
Automated backport with mergify
backport-8.11
Automated backport with mergify
Profiling
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we amend the instructions to delete data on profiling upgrade (only required for pre-GA versions) to also include deletion of index templates, component templates and the ILM policy. This ensures a smooth upgrade without any leftovers.