Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM] Remove FID and add INP #3531

Merged
merged 4 commits into from
Jan 12, 2024
Merged

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Jan 10, 2024

Closes #3424

Replaces first input delay (FID) in with of interaction to next paint (INP) metrics.

  • Update text
  • Update images

Note: Once we've finalized the language here, I'll make sure those changes are reflected in the APM RUM Agent docs, too.

@colleenmcginnis colleenmcginnis added the backport-8.12 Automated backport with mergify label Jan 10, 2024
@colleenmcginnis colleenmcginnis self-assigned this Jan 10, 2024
Copy link
Contributor

A documentation preview will be available soon:

paulb-elastic
paulb-elastic previously approved these changes Jan 11, 2024
Copy link
Contributor

@paulb-elastic paulb-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @colleenmcginnis. I really like the table you added, making it very clear what metrics will appear for which version combinations of the RUM Agent and Kibana.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review January 12, 2024 16:16
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner January 12, 2024 16:16
@colleenmcginnis
Copy link
Contributor Author

👋 @elastic/obs-docs this is ready for a code owner review!

mdbirnstiehl
mdbirnstiehl previously approved these changes Jan 12, 2024
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very small comment that you can potentially ignore.

docs/en/observability/user-experience.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in 63c656e LGTM

Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the RUM consistification looks good to me!

@colleenmcginnis colleenmcginnis merged commit a06b7ec into elastic:main Jan 12, 2024
6 checks passed
@colleenmcginnis colleenmcginnis deleted the issue-3424 branch January 12, 2024 22:54
mergify bot pushed a commit that referenced this pull request Jan 12, 2024
* update text

* update images

* consistify format of APM RUM agent

consistify format of APM RUM agent

* address feedback from @bmorelli25

(cherry picked from commit a06b7ec)
colleenmcginnis added a commit that referenced this pull request Jan 16, 2024
* update text

* update images

* consistify format of APM RUM agent

consistify format of APM RUM agent

* address feedback from @bmorelli25

(cherry picked from commit a06b7ec)

Co-authored-by: Colleen McGinnis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.12 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RUM | User Experience] Update to remove FID and add INP
4 participants