-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM] Remove FID and add INP #3531
Conversation
A documentation preview will be available soon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @colleenmcginnis. I really like the table you added, making it very clear what metrics will appear for which version combinations of the RUM Agent and Kibana.
👋 @elastic/obs-docs this is ready for a code owner review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very small comment that you can potentially ignore.
consistify format of APM RUM agent
63c656e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in 63c656e
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the RUM consistification looks good to me!
* update text * update images * consistify format of APM RUM agent consistify format of APM RUM agent * address feedback from @bmorelli25 (cherry picked from commit a06b7ec)
* update text * update images * consistify format of APM RUM agent consistify format of APM RUM agent * address feedback from @bmorelli25 (cherry picked from commit a06b7ec) Co-authored-by: Colleen McGinnis <[email protected]>
Closes #3424
Replaces first input delay (FID) in with of interaction to next paint (INP) metrics.
Note: Once we've finalized the language here, I'll make sure those changes are reflected in the APM RUM Agent docs, too.