-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify synthetics params / secrets docs #3672
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -2,10 +2,12 @@ | |||||||||||||||||
[[synthetics-params-secrets]] | ||||||||||||||||||
= Work with params and secrets | ||||||||||||||||||
|
||||||||||||||||||
Params allow you to use dynamically defined values, including sensitive information, in your | ||||||||||||||||||
Params allow you to use dynamically defined values, in your | ||||||||||||||||||
synthetic monitors. For example, you may want to test a production website with a particular | ||||||||||||||||||
demo account whose password is only known to the team managing the synthetic monitors. | ||||||||||||||||||
|
||||||||||||||||||
Please read the <<synthetics-sensitive-secret, documentation on sensitive values>>for more information on security-sensitive use cases. | ||||||||||||||||||
vigneshshanmugam marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||||||
|
||||||||||||||||||
[discrete] | ||||||||||||||||||
[[synthetics-params-secrets-define]] | ||||||||||||||||||
= Define params | ||||||||||||||||||
|
@@ -148,11 +150,15 @@ Your synthetics scripts may require the use of passwords or other sensitive secr | |||||||||||||||||
|
||||||||||||||||||
[WARNING] | ||||||||||||||||||
==== | ||||||||||||||||||
Because synthetics scripts have no limitations, a malicious script author could write a | ||||||||||||||||||
synthetics journey that exfiltrates `params` and other data at runtime. | ||||||||||||||||||
Please note that params are viewable in plain-text by administrators and other users with "all" privileges for | ||||||||||||||||||
the synthetics app. | ||||||||||||||||||
Additionally, note that synthetics scripts have no limitations on accessing these values, and a malicious script author could write a | ||||||||||||||||||
synthetics journey that exfiltrates `params` and other data at runtime. | ||||||||||||||||||
Comment on lines
+153
to
+156
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
Do *not* to use truly sensitive passwords (for example, an admin password or a real credit card) | ||||||||||||||||||
in *any* synthetics tools. | ||||||||||||||||||
Instead, set up limited demo accounts, or fake credit cards with limited functionality. | ||||||||||||||||||
If you want to limit access to parameters ensure that that users who are not supposed to access those values do not have "all" privileges | ||||||||||||||||||
vigneshshanmugam marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||
for the Synthetics app, and that any scripts that use those values do not leak them in network requests or screenshots. | ||||||||||||||||||
==== | ||||||||||||||||||
|
||||||||||||||||||
If you are managing monitors with projects, you can use environment variables | ||||||||||||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.