-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Clarify AI Assistant will spawn ML nodes #3687
Conversation
Clarify AI Assistant will spawn ML nodes
A documentation preview will be available soon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs. Just some minor changes to follow Elastic style and avoid what grammarians call an unclear antecedent.
@lucabelluccini Do we want to port this change to the serverless docs, too? |
Co-authored-by: DeDe Morton <[email protected]>
Hello @dedemorton - thanks for the review. I think we need some inputs from engineering as:
|
@dgieselaar Can you respond to Lucas' comments here so we can finalize these changes? Thanks! (My apologies if I'm pinging the wrong person here. I'm still trying to figure out who knows what on the team.) |
I assume you meant to say 'disabling AI Assistant / KB' ? The AI Assistant will not explicitly scale down ML nodes if it is disabled.
I'm unfamiliar with how autoscaling works in ML, but happy to ask around: https://elastic.slack.com/archives/C2AJLJHMM/p1711029351315459 |
@CoenWarmer Can you help me interpret the response to the question about autoscaling? The response includes a link to a document that "could be out of date" and the code for autoscaling, so I'm still not sure what, if anything, I need to say in the serverless docs. |
@emma-raffenne can you help us move this forward? |
@bmorelli25 Emma is on PTO & Coen is on leave, I will pick it up tomorrow, and apologies for the delay. |
@bmorelli25 Please let us know if after Dario's comment you need more input from our side. |
@dedemorton do you have everything you need for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on Slack, I would suggest to remove wording around disabling the AI Assistant as there are several ways to do this and there's no impact on the ML nodes. Other than that it looks good
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba) # Conflicts: # docs/en/observability/observability-ai-assistant.asciidoc
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba)
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba)
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba)
Only some backports were created successfully. This will be fixed in #4109. @dedemorton we'll need to remove the labels for the failing backports and re-add them after 4109 is merged. |
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba)
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba)
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba)
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba) Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba) Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba) Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba) Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba) Co-authored-by: Luca Belluccini <[email protected]>
…#4105) * [DOCS] Clarify AI Assistant will spawn ML nodes (#3687) Co-authored-by: Luca Belluccini <[email protected]> Co-authored-by: DeDe Morton <[email protected]>
Co-authored-by: DeDe Morton <[email protected]> (cherry picked from commit f1e14ba) Co-authored-by: Luca Belluccini <[email protected]>
Clarify AI Assistant will spawn ML nodes
To the doc writers: