Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Clarify AI Assistant will spawn ML nodes #3687

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Mar 19, 2024

Clarify AI Assistant will spawn ML nodes

To the doc writers:

  • please change wording
  • backport to all versions back to AI Assistant pages got created
  • add an additional paragraph if the use of AI Assistant / Knowledge Base implies ML Nodes will no more be scaled down back to 0

Clarify AI Assistant will spawn ML nodes
@lucabelluccini lucabelluccini requested a review from a team as a code owner March 19, 2024 08:53
Copy link
Contributor

A documentation preview will be available soon:

@dedemorton dedemorton self-requested a review March 19, 2024 16:20
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. Just some minor changes to follow Elastic style and avoid what grammarians call an unclear antecedent.

docs/en/observability/observability-ai-assistant.asciidoc Outdated Show resolved Hide resolved
@dedemorton dedemorton added backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.12 Automated backport with mergify backport-8.13 Automated backport with mergify labels Mar 19, 2024
@dedemorton
Copy link
Contributor

@lucabelluccini Do we want to port this change to the serverless docs, too?

@lucabelluccini
Copy link
Contributor Author

Hello @dedemorton - thanks for the review.

I think we need some inputs from engineering as:

  • It would be valuable to also mention the fact enabling AI Assistant / KB will not scale down ML nodes (I am not certain)
  • I think in serverless the autoscaling of ML doesn't work in the same way

@dedemorton
Copy link
Contributor

dedemorton commented Mar 19, 2024

@dgieselaar Can you respond to Lucas' comments here so we can finalize these changes? Thanks! (My apologies if I'm pinging the wrong person here. I'm still trying to figure out who knows what on the team.)

@CoenWarmer
Copy link

CoenWarmer commented Mar 21, 2024

Hello @dedemorton - thanks for the review.

I think we need some inputs from engineering as:

  • It would be valuable to also mention the fact enabling AI Assistant / KB will not scale down ML nodes (I am not certain)

I assume you meant to say 'disabling AI Assistant / KB' ? The AI Assistant will not explicitly scale down ML nodes if it is disabled.

  • I think in serverless the autoscaling of ML doesn't work in the same way

I'm unfamiliar with how autoscaling works in ML, but happy to ask around:

https://elastic.slack.com/archives/C2AJLJHMM/p1711029351315459

@dedemorton
Copy link
Contributor

@CoenWarmer Can you help me interpret the response to the question about autoscaling? The response includes a link to a document that "could be out of date" and the code for autoscaling, so I'm still not sure what, if anything, I need to say in the serverless docs.

@bmorelli25 bmorelli25 added the backport-8.14 Automated backport with mergify label Apr 18, 2024
@bmorelli25
Copy link
Member

@emma-raffenne can you help us move this forward?

@dgieselaar
Copy link
Member

@bmorelli25 Emma is on PTO & Coen is on leave, I will pick it up tomorrow, and apologies for the delay.

@emma-raffenne
Copy link

@bmorelli25 Please let us know if after Dario's comment you need more input from our side.

@bmorelli25 bmorelli25 added the backport-8.15 Automated backport with mergify label Jul 9, 2024
@bmorelli25
Copy link
Member

@dedemorton do you have everything you need for this PR?

Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Slack, I would suggest to remove wording around disabling the AI Assistant as there are several ways to do this and there's no impact on the ML nodes. Other than that it looks good

@dedemorton dedemorton merged commit f1e14ba into elastic:8.12 Aug 2, 2024
9 checks passed
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)

# Conflicts:
#	docs/en/observability/observability-ai-assistant.asciidoc
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)
@bmorelli25 bmorelli25 mentioned this pull request Aug 2, 2024
3 tasks
@bmorelli25
Copy link
Member

Only some backports were created successfully. This will be fixed in #4109.

@dedemorton we'll need to remove the labels for the failing backports and re-add them after 4109 is merged.

@bmorelli25 bmorelli25 added backport-8.12 Automated backport with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify backport-main Automated backport with mergify and removed backport-8.12 Automated backport with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify labels Aug 2, 2024
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)
dedemorton pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)

Co-authored-by: Luca Belluccini <[email protected]>
dedemorton pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)

Co-authored-by: Luca Belluccini <[email protected]>
@dedemorton dedemorton added backport-8.12 Automated backport with mergify and removed backport-8.12 Automated backport with mergify labels Aug 2, 2024
dedemorton pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)

Co-authored-by: Luca Belluccini <[email protected]>
dedemorton pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)

Co-authored-by: Luca Belluccini <[email protected]>
dedemorton pushed a commit that referenced this pull request Aug 2, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)

Co-authored-by: Luca Belluccini <[email protected]>
@dedemorton dedemorton removed the backport-8.12 Automated backport with mergify label Aug 2, 2024
dedemorton added a commit that referenced this pull request Aug 2, 2024
…#4105)

* [DOCS] Clarify AI Assistant will spawn ML nodes (#3687)

Co-authored-by: Luca Belluccini <[email protected]>
Co-authored-by: DeDe Morton <[email protected]>
dedemorton pushed a commit that referenced this pull request Aug 5, 2024
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit f1e14ba)

Co-authored-by: Luca Belluccini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.9 Automated backport with mergify backport-8.10 Automated backport with mergify backport-8.11 Automated backport with mergify backport-8.13 Automated backport with mergify backport-8.14 Automated backport with mergify backport-8.15 Automated backport with mergify backport-main Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants